731822 - No signature summary in report/list of "/"-containing signature

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Kaiser]

This report/list gets no signature summary:

https://crash-stats.mozilla.com/report/list?signature=java.lang.RuntimeException%3A%20Unable%20to%20resume%20activity%20%7Borg.mozilla.fennec%2Forg.mozilla.fennec.App%7D%3A%20java.lang.RuntimeException%3A%20Failure%20delivering%20result%20ResultInfo%7Bwho%3Dnull%2C%20request%3D2%2C%20result%3D-1%2C%20data%3DIntent%20%7B%20%28has%20extras%29%20%7D%7D%20to%20activity%20%7Borg.mozilla.f...

The whole report/list errored out before bug 724670 was fixed, so we've improved, but now the signature summary XHR comes back with an error 500, here's what inspecting the relevant network request from the web developer panel tells me:

Request URL:
    https://crash-stats.mozilla.com/signature_summary/json_data?range_value=1&range_unit=weeks&signature=java.lang.RuntimeException%3A%20Unable%20to%20resume%20activity%20%7Borg.mozilla.fennec%2Forg.mozilla.fennec.App%7D%3A%20java.lang.RuntimeException%3A%20Failure%20delivering%20result%20ResultInfo%7Bwho%3Dnull%2C%20request%3D2%2C%20result%3D-1%2C%20data%3DIntent%20%7B%20%28has%20extras%29%20%7D%7D%20to%20activity%20%7Borg.mozilla.f...
  
  
    Request Method:
    GET
  
  
    Status Code:
    HTTP/1.1 500 Internal Server Error

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

Pull request: https://github.com/mozilla/socorro/pull/414

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Steps to QA
-----------

1. Go to advanced search and search for FennecAndroid crashes with a signature containing a slash ('/');
2. Click on a signature to go to report/list;
3. Verify that the Summary tab shows results.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/6df8779e0407965d08113fb5bb69230ade90353f
Fixes bug 731822 - Decode double encoded slashes in signature summary service.

https://github.com/mozilla/socorro/commit/fe85bed80e7951807d3b5ea2ccb2ad2bb10bbdc5
Merge pull request #414 from AdrianGaudebert/731822-decode-slash-signature-summary

Fixes bug 731822 - Decode double encoded slashes in signature summary service.

Comment 4

[Matt Brandt [:mbrandt]]

QA verified on stage - locating reports, either by browsing or using the advanced search correct return the expected number of results when viewing crashes that contain '/'

https://crash-stats.allizom.org/report/list?product=Firefox&query_search=signature&query_type=contains&query=%2F&reason_type=contains&date=03%2F20%2F2012%2018%3A27%3A56&range_value=3&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=mozilla%3A%3Aoperator%2F%3Cint%3E%28mozilla%3A%3ACheckedInt%3Cint%3E%20const%26%2C%20mozilla%3A%3ACheckedInt%3Cint%3E%20const%26%29

https://crash-stats.allizom.org/report/list?product=Firefox&query_search=signature&query_type=contains&query=%2F&reason_type=contains&date=03%2F20%2F2012%2018%3A27%3A56&range_value=3&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=gfx3DMatrix%3A%3Aoperator%2F%3D%28double%29

https://crash-stats.allizom.org/report/list?product=FennecAndroid&query_search=signature&query_type=contains&query=%2F&reason_type=contains&date=03%2F20%2F2012%2018%3A27%3A56&range_value=3&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=java.lang.RuntimeException%3A%20Unable%20to%20resume%20activity%20{org.mozilla.fennec%2Forg.mozilla.fennec.App}%3A%20java.lang.RuntimeException%3A%20Failure%20delivering%20result%20ResultInfo{who%3Dnull%2C%20request%3D2%2C%20result%3D-1%2C%20data%3DIntent%20{%20%28has%20extras%29%20}}%20to%20activity%20{org.mozilla.f...