731998 - Warning messages should be positioned under mandatory fields, not above in Confirm Details page.

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, enhancement)

Description

[Victor Carciu]

Attachment: Screenshot

Prerequisites:
Mozilla/5.0 (Windows NT 5.1; rv:10.0) Gecko/20100101 Firefox/10.0

Steps to reproduce:
1.Go to apps marketplace and sign in : https://marketplace-dev.allizom.org/en-US/developers/submissions
2.Select any premium owned app and select "Manage PayPal" from the left side of the screen
3.Click "Set up permissions" button
4.Login to PayPal , grant permissions and return to marketplace
5.At confirm details page delete all fields and press Continue.

Expected Results:
"Country" and "Address one" fields are mandatory, so the warning messages should be positioned under these fields.

Actual Results:
The warning message("This field is required.") is positioned above the mandatory fields.

Note:The issue here is that this positioning is confusing because in the rest of marketplace-dev the warning messages are positioned under mandatory fields and the user will try to fill "Last Name " and "Country" in this page.

Please see attached screenshot.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

This is because we use django's default forms layout to print `form.as_p()`. We should use our styling, and this should fix itself.

Comment 2

[Potch [:potch]]

fixed by https://github.com/mozilla/zamboni/commit/38a471c

Comment 3

[Victor Carciu]

Verified as fixed.

Comment 4

[Victor Carciu]

Attachment: Postfix Screenshot