Closed
Bug 731998
Opened 12 years ago
Closed 12 years ago
Warning messages should be positioned under mandatory fields, not above in Confirm Details page.
Categories
(addons.mozilla.org Graveyard :: Discovery Pane, enhancement)
addons.mozilla.org Graveyard
Discovery Pane
Tracking
(Not tracked)
VERIFIED
FIXED
6.4.6
People
(Reporter: vcarciu, Assigned: potch)
References
()
Details
Attachments
(2 files)
Prerequisites: Mozilla/5.0 (Windows NT 5.1; rv:10.0) Gecko/20100101 Firefox/10.0 Steps to reproduce: 1.Go to apps marketplace and sign in : https://marketplace-dev.allizom.org/en-US/developers/submissions 2.Select any premium owned app and select "Manage PayPal" from the left side of the screen 3.Click "Set up permissions" button 4.Login to PayPal , grant permissions and return to marketplace 5.At confirm details page delete all fields and press Continue. Expected Results: "Country" and "Address one" fields are mandatory, so the warning messages should be positioned under these fields. Actual Results: The warning message("This field is required.") is positioned above the mandatory fields. Note:The issue here is that this positioning is confusing because in the rest of marketplace-dev the warning messages are positioned under mandatory fields and the user will try to fill "Last Name " and "Country" in this page. Please see attached screenshot.
Comment 1•12 years ago
|
||
This is because we use django's default forms layout to print `form.as_p()`. We should use our styling, and this should fix itself.
Updated•12 years ago
|
Assignee: nobody → cvan
Target Milestone: --- → 6.4.5
Updated•12 years ago
|
Assignee: cvan → thepotch
OS: Windows XP → All
Hardware: x86 → All
Target Milestone: 6.4.5 → 6.4.6
Assignee | ||
Comment 2•12 years ago
|
||
fixed by https://github.com/mozilla/zamboni/commit/38a471c
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 4•12 years ago
|
||
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•