732962 - Implement signing on demand for xulrunner

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P2)

Description

[Rail Aliiev [:rail]]

Attachment: sign xulrunner

* xulrunner shouldn't be codesigned internally (our current practice)
* GPG sign SDK

Comment 1

[Rail Aliiev [:rail]]

Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

http://hg.mozilla.org/integration/mozilla-inbound/rev/5b2ba557ec83

Comment 2

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/5b2ba557ec83

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

This patch implements signing on demand for xulrunner. Xulrunner isn't a part of Firefox CI process (only nightlies) and exists in release builds. The patch simplifies the release build procedure by removing xulrunner signing step which is manual right now.

Regression caused by (bug #): none
Testing completed (on m-c, etc.): tested in dev environment by running staging releases 
Risk to taking this patch (and alternatives if risky): very low
String changes made by this patch: none

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

[Triage comment]
Approval for low-risk, non-CI affecting.

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

http://hg.mozilla.org/releases/mozilla-beta/rev/438dd47e6f69

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

I would like to land this patch on m-r and esr10 branches. 12.0b1 release passed without any problems. The patch will remove error-prone manual steps used by releng.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

[Triage Comment]
Looks foo, low risk, please go ahead.

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

http://hg.mozilla.org/releases/mozilla-esr10/rev/2ef0aaa7a70d
http://hg.mozilla.org/releases/mozilla-release/rev/c3be4bb8ba93