Closed Bug 732962 Opened 8 years ago Closed 8 years ago

Implement signing on demand for xulrunner

Categories

(Firefox Build System :: General, defect, P2)

defect

Tracking

(firefox-esr10 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr10 --- fixed

People

(Reporter: rail, Assigned: rail)

References

Details

(Whiteboard: [Leave open after merge])

Attachments

(1 file)

Attached patch sign xulrunnerSplinter Review
* xulrunner shouldn't be codesigned internally (our current practice)
* GPG sign SDK
Attachment #602895 - Flags: review?(ted.mielczarek)
Attachment #602895 - Flags: review?(catlee)
Attachment #602895 - Flags: review?(catlee) → review+
Attachment #602895 - Flags: review?(ted.mielczarek) → review+
Whiteboard: [Leave open after merge]
Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

This patch implements signing on demand for xulrunner. Xulrunner isn't a part of Firefox CI process (only nightlies) and exists in release builds. The patch simplifies the release build procedure by removing xulrunner signing step which is manual right now.

Regression caused by (bug #): none
Testing completed (on m-c, etc.): tested in dev environment by running staging releases 
Risk to taking this patch (and alternatives if risky): very low
String changes made by this patch: none
Attachment #602895 - Flags: approval-mozilla-beta?
Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

[Triage comment]
Approval for low-risk, non-CI affecting.
Attachment #602895 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

I would like to land this patch on m-r and esr10 branches. 12.0b1 release passed without any problems. The patch will remove error-prone manual steps used by releng.
Attachment #602895 - Flags: approval-mozilla-release?
Attachment #602895 - Flags: approval-mozilla-esr10?
Comment on attachment 602895 [details] [diff] [review]
sign xulrunner

[Triage Comment]
Looks foo, low risk, please go ahead.
Attachment #602895 - Flags: approval-mozilla-release?
Attachment #602895 - Flags: approval-mozilla-release+
Attachment #602895 - Flags: approval-mozilla-esr10?
Attachment #602895 - Flags: approval-mozilla-esr10+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.