Closed Bug 733102 Opened 12 years ago Closed 12 years ago

change elasticsearch search view to not use db

Categories

(support.mozilla.org :: Search, defect, P1)

Product:
support.mozilla.org
Component:
Search
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2012.6

People

(Reporter: willkg, Assigned: willkg)

References

Details

(Whiteboard: u=dev c=search p=3) 

elasticutils has a bizarro excerpting/highlight implementation that allowed our ES code to play nice with our Sphinx code.

After splitting the search view, we should fix the excerpt/highlight code in elasticutils and fix the search view so that doing an elasticsearch search never touches the database.

Making this block bug #729688. This will improve performance for elasticsearch search.
Changing the title.

The work required here is:

1. fix excerpt/highlight code in elasticutils so that it's all done in one pass and doesn't require objects and build_excerpt calls

2. add the get_absolute_url() return values to the index

After doing those, we should be able to build results solely from ES results.
Summary: rewrite excerpt/highlight code for elasticsearch → change elasticsearch search view to not use db
Putting this in the 2012.6 sprint. I'm making it a 3pter because it involves reimplementing excerpting/highlighting in elasticutils and I need to spend some time to "do it right".
Whiteboard: u=dev c=search s=2012.6 p=3
Priority: -- → P1
Whiteboard: u=dev c=search s=2012.6 p=3 → u=dev c=search p=3
Target Milestone: --- → 2012.6
Assignee: nobody → willkg
That turned out to be harder than I thought in some places and easier in others. I have a redo-highlighting branch in elasticutils which has a commit that needs peer-review:

https://github.com/willkg/elasticutils/commit/d2c5aa3878a940d4f97bb1deef8c4206363bd3b7

Once that lands in the sumo branch, I can add the right git sha for elasticutils and check everything in my es-and-db branch:

https://github.com/willkg/kitsune/tree/733102-es-and-db

Then that'll need peer review. Then if all is well, we'll land that, too.
Status: NEW → ASSIGNED
Pushed to master in https://github.com/mozilla/kitsune/commit/ab4919f09b4328620c236d0398399e0166ac08e8

Pushed to production this morning.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.