Open Bug 733396 Opened 10 years ago Updated 7 years ago

XPFE AutoComplete: rewrite it to initialise lazily (etc)

Categories

(SeaMonkey :: Autocomplete, defect)

defect
Not set
minor

Tracking

(Not tracked)

People

(Reporter: sgautherie, Unassigned)

References

(Blocks 1 open bug, )

Details

Bug 718237 comment 26:
{
neil@parkwaycc.co.uk      2012-03-06 01:09:09 PST

only once LDAP has been switched to be a toolkit search session will we be able to remove all of the hacks we have that support the current version thus allowing us to rewrite the widget to initialise lazily.
}

Current XPFE widget needs to initialize early: "before onload event".
For example, we had to update some tests to take this into account.
Blocks: 718237
Blocks: 727954
Now that bug 452232 is fixed, we should be able to proceed with this bug.

Neil, could you check and list (or even fix) what should be "updated" on 'XPFE AutoComplete' component ?
Flags: needinfo?(neil)
Target Milestone: Future → ---
Well, all the code that relates to the XPFE interfaces has to go, the obvious references being initSearchSessions, removeSession, syncSessions and autoComplete.
startLookup and stopLookup have to be adjusted to use toolkit methods directly instead of going through mAutoCompleteSession.
mAutoCompleteListener, processResults and in fact anything accessing mLastResults also has to be adjusted, which is going to be a big change.
At that point we can then remove mAutoCompleteSession, create mSessions lazily, remove addSession, and possibly add mSearchNames and change mSessions etc. from objects into arrays too.
Oh, and then we should also support getImageAt.
Flags: needinfo?(neil)
Depends on: 896213
(In reply to neil@parkwaycc.co.uk from comment #2)
> Well, all the code that relates to the XPFE interfaces has to go, the
> obvious references being initSearchSessions, removeSession, syncSessions and
> autoComplete.
> startLookup and stopLookup have to be adjusted to use toolkit methods
> directly instead of going through mAutoCompleteSession.
> mAutoCompleteListener, processResults and in fact anything accessing
> mLastResults also has to be adjusted, which is going to be a big change.
> At that point we can then remove mAutoCompleteSession, create mSessions
> lazily, remove addSession, and possibly add mSearchNames and change
> mSessions etc. from objects into arrays too.
Most of this was covered by bug 896213, except that mAutoCompleteListener was actually turned into mAutoCompleteObserver, while mSessions is still created eagerly (which is this bug).

> Oh, and then we should also support getImageAt.
Fixed in bug 906920.
You need to log in before you can comment on or make changes to this bug.