Remove usage of XPFE autocomplete interfaces from the XBL widget

RESOLVED FIXED in seamonkey2.23

Status

SeaMonkey
Autocomplete
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug)

unspecified
seamonkey2.23
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Now that LDAP is no longer using the XPFE autocomplete interfaces, we can remove them from the XBL widget.
(Assignee)

Comment 1

4 years ago
Created attachment 778885 [details] [diff] [review]
Proposed patch

Also happens to fix a potential race condition on Linux whereby results may be invalidated incorrectly if they arrive in a different order to the search list. (Don't worry, the race condition is very hard to detect.)
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #778885 - Flags: review?(iann_bugzilla)
Attachment #778885 - Flags: feedback?(philip.chee)
(Assignee)

Comment 2

4 years ago
Will file followup bugs on:
* Removing obsolete files from the tree
* Adding other toolkit features, such as
  o support for getLabelAt
  o support for getImageAt
  o support for removeValueAt

Comment 3

4 years ago
Comment on attachment 778885 [details] [diff] [review]
Proposed patch

While testing I managed to trigger an error:

Wed Jul 31 2013 00:23:22
Error: TypeError: input[0].syncSessions is not a function
Source file: chrome://messenger/content/addressbook/abMailListDialog.js
Line: 443

Combing through MXR I see several files that need to be updated:

http://mxr.mozilla.org/comm-central/search?string=syncSessions&find=&findi=&filter=&hitlimit=&tree=comm-central
/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml
/mail/components/compose/content/addressingWidgetOverlay.js
/mailnews/addrbook/content/abMailListDialog.js
/suite/mailnews/compose/addressingWidgetOverlay.js

http://mxr.mozilla.org/comm-central/search?string=searchSessions&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
/mozilla/extensions/inspector/resources/content/toolboxOverlay.xul
/mozilla/xpfe/components/autocomplete/test/autocomplete_test.xul

(Lightning)
http://mxr.mozilla.org/comm-central/search?string=addSession&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
http://mxr.mozilla.org/comm-central/search?string=removeSession&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Except for these all the autocomplete textboxes I tested didn't show any problems.
Attachment #778885 - Flags: feedback?(philip.chee)
(Assignee)

Comment 4

4 years ago
(In reply to Philip Chee from comment #3)
> http://mxr.mozilla.org/comm-central/search?string=syncSessions
> /calendar/base/content/dialogs/calendar-event-dialog-attendees.xml
> /mail/components/compose/content/addressingWidgetOverlay.js
> /mailnews/addrbook/content/abMailListDialog.js
> /suite/mailnews/compose/addressingWidgetOverlay.js
Right, these should have been removed by bug 452232, but they weren't. Oops.

> http://mxr.mozilla.org/comm-central/search?string=searchSessions
> /mozilla/extensions/inspector/resources/content/toolboxOverlay.xul
> /mozilla/xpfe/components/autocomplete/test/autocomplete_test.xul
inspector needs it for backcompat. xpfe test is obsolete and unused, I was going to remove it along with the xpfe src and public files.

> http://mxr.mozilla.org/comm-central/search?string=addSession
> http://mxr.mozilla.org/comm-central/search?string=removeSession
These also need to be removed.
(Assignee)

Updated

4 years ago
Depends on: 899822

Comment 5

4 years ago
Comment on attachment 778885 [details] [diff] [review]
Proposed patch

I was going to file some dependent bugs but I see you have already done it.
Attachment #778885 - Flags: feedback+

Updated

4 years ago
Depends on: 899958

Updated

4 years ago
Attachment #778885 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 6

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/73ec9b19228a
https://hg.mozilla.org/mozilla-central/rev/73ec9b19228a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.23
(Assignee)

Updated

4 years ago
Blocks: 906920
You need to log in before you can comment on or make changes to this bug.