Last Comment Bug 896213 - Remove usage of XPFE autocomplete interfaces from the XBL widget
: Remove usage of XPFE autocomplete interfaces from the XBL widget
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: Autocomplete (show other bugs)
: unspecified
: All All
: -- normal (vote)
: seamonkey2.23
Assigned To: neil@parkwaycc.co.uk
:
:
Mentors:
Depends on: 452232 899822 899958
Blocks: 733396 906920
  Show dependency treegraph
 
Reported: 2013-07-20 16:07 PDT by neil@parkwaycc.co.uk
Modified: 2013-08-19 15:52 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Proposed patch (33.51 KB, patch)
2013-07-20 16:11 PDT, neil@parkwaycc.co.uk
iann_bugzilla: review+
philip.chee: feedback+
Details | Diff | Splinter Review

Description neil@parkwaycc.co.uk 2013-07-20 16:07:16 PDT
Now that LDAP is no longer using the XPFE autocomplete interfaces, we can remove them from the XBL widget.
Comment 1 neil@parkwaycc.co.uk 2013-07-20 16:11:07 PDT
Created attachment 778885 [details] [diff] [review]
Proposed patch

Also happens to fix a potential race condition on Linux whereby results may be invalidated incorrectly if they arrive in a different order to the search list. (Don't worry, the race condition is very hard to detect.)
Comment 2 neil@parkwaycc.co.uk 2013-07-20 16:18:07 PDT
Will file followup bugs on:
* Removing obsolete files from the tree
* Adding other toolkit features, such as
  o support for getLabelAt
  o support for getImageAt
  o support for removeValueAt
Comment 3 Philip Chee 2013-07-30 10:08:53 PDT
Comment on attachment 778885 [details] [diff] [review]
Proposed patch

While testing I managed to trigger an error:

Wed Jul 31 2013 00:23:22
Error: TypeError: input[0].syncSessions is not a function
Source file: chrome://messenger/content/addressbook/abMailListDialog.js
Line: 443

Combing through MXR I see several files that need to be updated:

http://mxr.mozilla.org/comm-central/search?string=syncSessions&find=&findi=&filter=&hitlimit=&tree=comm-central
/calendar/base/content/dialogs/calendar-event-dialog-attendees.xml
/mail/components/compose/content/addressingWidgetOverlay.js
/mailnews/addrbook/content/abMailListDialog.js
/suite/mailnews/compose/addressingWidgetOverlay.js

http://mxr.mozilla.org/comm-central/search?string=searchSessions&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
/mozilla/extensions/inspector/resources/content/toolboxOverlay.xul
/mozilla/xpfe/components/autocomplete/test/autocomplete_test.xul

(Lightning)
http://mxr.mozilla.org/comm-central/search?string=addSession&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central
http://mxr.mozilla.org/comm-central/search?string=removeSession&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=comm-central

Except for these all the autocomplete textboxes I tested didn't show any problems.
Comment 4 neil@parkwaycc.co.uk 2013-07-30 13:26:41 PDT
(In reply to Philip Chee from comment #3)
> http://mxr.mozilla.org/comm-central/search?string=syncSessions
> /calendar/base/content/dialogs/calendar-event-dialog-attendees.xml
> /mail/components/compose/content/addressingWidgetOverlay.js
> /mailnews/addrbook/content/abMailListDialog.js
> /suite/mailnews/compose/addressingWidgetOverlay.js
Right, these should have been removed by bug 452232, but they weren't. Oops.

> http://mxr.mozilla.org/comm-central/search?string=searchSessions
> /mozilla/extensions/inspector/resources/content/toolboxOverlay.xul
> /mozilla/xpfe/components/autocomplete/test/autocomplete_test.xul
inspector needs it for backcompat. xpfe test is obsolete and unused, I was going to remove it along with the xpfe src and public files.

> http://mxr.mozilla.org/comm-central/search?string=addSession
> http://mxr.mozilla.org/comm-central/search?string=removeSession
These also need to be removed.
Comment 5 Philip Chee 2013-07-31 02:13:41 PDT
Comment on attachment 778885 [details] [diff] [review]
Proposed patch

I was going to file some dependent bugs but I see you have already done it.
Comment 7 Carsten Book [:Tomcat] 2013-08-13 05:06:17 PDT
https://hg.mozilla.org/mozilla-central/rev/73ec9b19228a

Note You need to log in before you can comment on or make changes to this bug.