734027 - Non-ASCII filename is shown as escaped unicode when saving a snapshot from video

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Mihaela Velimiroviciu (:mihaelav)]

Attachment: screenshot

Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20120307 Firefox/13.0a1

Steps to reproduce:
1. Give video file Non-ASCII filename, for example: Basilique du Sacré-Cœur de Montmartre.ogg
2. Play this file in Firefox
3. Right click on the video and select "Save Snapshot as..."

Actual result:
Snapshot file shows escaped unicode instead of non ASCII characters

Expected result:
Snapshot file name should contain the correct non-ascii characters.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

This bug is very similar to bug 694434.

It looks like we will need to use |decodeURI| on the fileBaseName at 
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/nsContextMenu.js#853

Comment 2

[Ekanan Ketunuti]

Attachment: Added decodeURI to decode percent encoding on non-ASCII filename when saving a snapshot from video

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 604004 [details] [diff] [review]
Added decodeURI to decode percent encoding on non-ASCII filename when saving a snapshot from video

Review of attachment 604004 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! I tested this out and it works great.

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/299e9dc61190

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/299e9dc61190