734089 - Don't set content.image.allow_locking to false on Fennec

Status: RESOLVED DUPLICATE of bug 691169

(Firefox for Android Graveyard :: General, defect)

Description

[Justin Lebar (not reading bugmail)]

When content.image.allow_locking is false, documents never lock their images.  As a result, imagelib has no idea which images are visible and which aren't, and when it goes to discard decoded image data, it may decode data from a visible image.

I have no idea if this even works, but if it does, it means that we end up re-decoding that image when it's drawn, which will be slow.

We're working on being able to discard images on the active tab (bug 689623), but I am skeptical that content.image.allow_locking = false is a good approximation.

Comment 1

[Justin Lebar (not reading bugmail)]

> and when it goes to discard decoded image data, it may decode data from a visible image.

"...it may *discard* data from a visible image"

Comment 2

[Justin Lebar (not reading bugmail)]

Attachment: Part 1: Don't set content.image.allow_locking = false on mobile.

Comment 3

[Justin Lebar (not reading bugmail)]

Attachment: Part 2: Add comments to mobile image prefs.

Comment 4

[Joe Drew (not getting mail)]

This is covered by bug 691169. They did this on purpose to save memory at the expense of flickering.

Comment 5

[Justin Lebar (not reading bugmail)]

Comment on attachment 604073 [details] [diff] [review]
Part 1: Don't set content.image.allow_locking = false on mobile.

I take the dupe to be an r- here.