Last Comment Bug 734232 - Make OpenSearch notify the user about who they're sending their search terms to.
: Make OpenSearch notify the user about who they're sending their search terms to.
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Mail Window Front End (show other bugs)
: unspecified
: x86 Mac OS X
: -- enhancement (vote)
: Thunderbird 13.0
Assigned To: Blake Winton (:bwinton) (:☕️)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-08 13:18 PST by Blake Winton (:bwinton) (:☕️)
Modified: 2012-03-12 14:28 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
The patch. (3.87 KB, patch)
2012-03-08 13:19 PST, Blake Winton (:bwinton) (:☕️)
no flags Details | Diff | Splinter Review
The patch with review comments (3.63 KB, patch)
2012-03-12 14:20 PDT, Mark Banner (:standard8)
standard8: review+
Details | Diff | Splinter Review

Description Blake Winton (:bwinton) (:☕️) 2012-03-08 13:18:42 PST

    
Comment 1 Blake Winton (:bwinton) (:☕️) 2012-03-08 13:19:20 PST
Uh, let's finish the title before submitting the bug, m'kay?  :P
Comment 2 Blake Winton (:bwinton) (:☕️) 2012-03-08 13:19:56 PST
Created attachment 604174 [details] [diff] [review]
The patch.

And here's the implementation.
Comment 3 Mark Banner (:standard8) 2012-03-12 14:20:36 PDT
Created attachment 605124 [details] [diff] [review]
The patch with review comments

This fixes Blake's patch with my review comments. Namely that the strings need to be renamed so that localisers are forced to pick them up.

I'll land this in a moment.
Comment 4 Mark Banner (:standard8) 2012-03-12 14:28:52 PDT
Checked in:

http://hg.mozilla.org/comm-central/rev/e827c650565c

Note You need to log in before you can comment on or make changes to this bug.