Closed
Bug 734734
Opened 12 years ago
Closed 12 years ago
build failure at thunderbird.mdimporter on case-sensitive filesystem
Categories
(Thunderbird :: Search, defect)
Tracking
(thunderbird-esr1012+ fixed)
RESOLVED
FIXED
Thunderbird 14.0
People
(Reporter: ul-mcamafia, Assigned: ul-mcamafia)
References
Details
Attachments
(2 files, 1 obsolete file)
2.39 KB,
patch
|
standard8
:
review+
standard8
:
approval-comm-esr10+
|
Details | Diff | Splinter Review |
1.24 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
building the xcode project fails on a case-sensitive filesystem due to thunderbird and Thunderbird may different files...
Assignee | ||
Updated•12 years ago
|
Attachment #604762 -
Flags: review?(dbienvenu)
Assignee | ||
Comment 1•12 years ago
|
||
discovered while buildung 10esr branch on osx 10.5.8, Xcode 3.1.4
Comment 2•12 years ago
|
||
Comment on attachment 604762 [details] [diff] [review] Make the xcode project case unambigious Stealing review. This looks wrong to be based on what I know of the history here, but I need to double check that first.
Attachment #604762 -
Flags: review?(dbienvenu) → review?(mbanner)
Assignee | ||
Comment 3•12 years ago
|
||
Fixing case should happen according to bug 698702
Depends on: 698702
Assignee | ||
Comment 4•12 years ago
|
||
Here is the error output after locally backing out above patch: mkdir /Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mail/components/search/mdimporter/build/Release/thunderbird.mdimporter/Contents/MacOS cd /Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mail/components/search/mdimporter setenv MACOSX_DEPLOYMENT_TARGET 10.5 /Developer/usr/bin/gcc-4.2 -arch i386 -bundle -isysroot /Developer/SDKs/MacOSX10.5.sdk -L/Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mail/components/search/mdimporter/build/Release -F/Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mail/components/search/mdimporter/build/Release -filelist /Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mail/components/search/mdimporter/build/TBSpotlight.build/Release/thunderbird.build/Objects-normal/i386/thunderbird.LinkFileList -mmacosx-version-min=10.5 -framework CoreFoundation -framework CoreServices -o /Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mail/components/search/mdimporter/build/Release/thunderbird.mdimporter/Contents/MacOS/thunderbird Touch /Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mail/components/search/mdimporter/build/Release/thunderbird.mdimporter cd /Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mail/components/search/mdimporter /usr/bin/touch -c /Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mail/components/search/mdimporter/build/Release/thunderbird.mdimporter ** BUILD SUCCEEDED ** mkdir -p ../../../../mozilla/dist/package /Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mozilla/config/nsinstall -L /Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mail/components/search/mdimporter "build/Release/Thunderbird.mdimporter" ../../../../mozilla/dist/package /Mozilla/src/comm-esr10/obj-i386-apple-darwin9.8.0/mozilla/config/nsinstall: cannot access build/Release/Thunderbird.mdimporter: No such file or directory gnumake[7]: *** [libs] Error 1 gnumake[6]: *** [libs] Error 2 gnumake[5]: *** [libs] Error 2 gnumake[4]: *** [libs_tier_platform] Error 2 gnumake[3]: *** [tier_platform] Error 2 gnumake[2]: *** [default] Error 2 gnumake[1]: *** [default] Error 2 gnumake: *** [build] Error 2
Comment 5•12 years ago
|
||
Comment on attachment 604762 [details] [diff] [review] Make the xcode project case unambigious This doesn't work, I end up with DailyDebug.app/Contents/Library/Spotlight/Thunderbird.mdimporter/Contents/MacOS/Thunderbird which would effectively revert bug 698702. Maybe you could just change mail/components/search/mdimporter/Makefile.in two lines below where you modified it in this patch so that Thunderbird.mdimporter is referenced as lower case?
Attachment #604762 -
Flags: review?(mbanner) → review-
Assignee | ||
Comment 6•12 years ago
|
||
Had to fix to lower-case thunderbird in mail/app/Makefile.in too, else the rsync fails. So not reverting changes done in bug 698702
Attachment #604762 -
Attachment is obsolete: true
Attachment #609549 -
Flags: review?(mbanner)
Comment 7•12 years ago
|
||
Thanks for the update. I've updated the patch to fix the bitrot against trunk. That seems that it will work fine.
Attachment #609665 -
Flags: review+
Updated•12 years ago
|
Assignee: nobody → ul.mcamafia
Updated•12 years ago
|
Attachment #609549 -
Attachment description: Fix building on case-sensitive filesystems → Fix building on case-sensitive filesystems [esr version]
Attachment #609549 -
Flags: review?(mbanner) → review+
Updated•12 years ago
|
tracking-thunderbird-esr10:
--- → 12+
Comment 8•12 years ago
|
||
I've checked this in for you: http://hg.mozilla.org/comm-central/rev/db1bae7de811 We'll land this on the esr branch before the next release.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment 9•12 years ago
|
||
Comment on attachment 609549 [details] [diff] [review] Fix building on case-sensitive filesystems [esr version] [Triage Comment] a=Standard8 for simple build system case fix on esr.
Attachment #609549 -
Flags: approval-comm-esr10+
Comment 10•12 years ago
|
||
Checked in for esr: http://hg.mozilla.org/releases/comm-esr10/rev/94677ba4bd4e
status-thunderbird-esr10:
--- → fixed
Updated•12 years ago
|
status-thunderbird-esr10:
fixed → ---
Updated•12 years ago
|
status-thunderbird-esr10:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•