734797 - Fennec APK has many duplicate files

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

The build process spits out many duplicate file warnings when building the APK. For example:

chrome/toolkit/skin/classic/mozapps/xpinstall/xpinstallItemGeneric.png
	is a duplicate of
chrome/toolkit/skin/classic/mozapps/extensions/category-extensions.png

The build also says:

WARNING: Found 81 duplicate files taking 653424 bytes

That's a half-meg of duplicate files that could presumably be trimmed, resulting in a smaller APK download.

Comment 1

[Aaron Train [:aaronmt]]

Should this block release?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

A build I just did showed these duplicates (much reduced from before):

Duplicates 51 bytes (2 times):
  chrome/en-US/locale/en-US/global-platform/mac/intl.properties
  chrome/en-US/locale/en-US/global-platform/win/intl.properties
  chrome/en-US/locale/en-US/global-platform/unix/intl.properties

Duplicates 94 bytes:
  chrome/en-US/locale/en-US/global-platform/win/platformKeys.properties
  chrome/en-US/locale/en-US/global-platform/unix/platformKeys.properties

Duplicates 296 bytes:
  chrome/en-US/locale/en-US/global-platform/win/accessible.properties
  chrome/en-US/locale/en-US/global-platform/unix/accessible.properties

Duplicates 1751 bytes (2 times):
  chrome/toolkit/skin/classic/global/icons/tabprompts-bgtexture.png
  chrome/toolkit/skin/classic/global/media/clicktoplay-bgtexture.png
  chrome/toolkit/skin/classic/global/inContentUI/background-texture.png

Duplicates 54 bytes:
  chrome/toolkit/skin/classic/global/arrow/arrow-rit.gif
  chrome/toolkit/skin/classic/global/arrow/arrow-rit-hov.gif

Duplicates 54 bytes:
  chrome/toolkit/skin/classic/global/arrow/arrow-lft-hov.gif
  chrome/toolkit/skin/classic/global/arrow/arrow-lft.gif

Duplicates 1302 bytes (2 times):
  chrome/toolkit/skin/classic/mozapps/xpinstall/xpinstallItemGeneric.png
  chrome/toolkit/skin/classic/mozapps/extensions/category-extensions.png
  chrome/toolkit/skin/classic/mozapps/extensions/extensionGeneric.png

Duplicates 544 bytes (2 times):
  chrome/toolkit/skin/classic/mozapps/plugins/pluginGeneric-16.png
  chrome/toolkit/skin/classic/mozapps/plugins/notifyPluginGeneric.png
  chrome/toolkit/skin/classic/mozapps/plugins/notifyPluginCrashed.png

Duplicates 699 bytes:
  chrome/toolkit/skin/classic/mozapps/plugins/notifyPluginBlocked.png
  chrome/toolkit/skin/classic/mozapps/plugins/notifyPluginOutdated.png

Duplicates 2410 bytes:
  chrome/toolkit/skin/classic/mozapps/extensions/category-languages.png
  chrome/toolkit/skin/classic/mozapps/extensions/localeGeneric.png

Duplicates 2185 bytes:
  chrome/toolkit/skin/classic/mozapps/extensions/themeGeneric.png
  chrome/toolkit/skin/classic/mozapps/extensions/category-themes.png

Duplicates 1665 bytes:
  chrome/toolkit/skin/classic/mozapps/extensions/dictionaryGeneric.png
  chrome/toolkit/skin/classic/mozapps/extensions/category-dictionaries.png

Duplicates 3243 bytes:
  chrome/toolkit/skin/classic/mozapps/update/downloadButtons.png
  chrome/toolkit/skin/classic/mozapps/downloads/downloadButtons.png

Duplicates 835 bytes:
  res/table-remove-column-active.gif
  res/table-remove-row-active.gif

Duplicates 841 bytes:
  res/table-remove-column-hover.gif
  res/table-remove-row-hover.gif

Duplicates 841 bytes:
  res/table-remove-column.gif
  res/table-remove-row.gif

WARNING: Found 16 duplicated files taking 20513 bytes (uncompressed)

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

if you remove these, does that change the apk size at all? I'd expect the zip compression to take care of that.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Those files turned out to be inside the omni.ja file. With the duplicates, my repack of omni.ja was 7561257 bytes and without the duplicates, it was 7538833 bytes (~20k smaller). I put the two omni.ja versions and repacked the APK with them; with the smaller omni.ja it went down from 28693778 to 28690781 (~3k smaller). Probably not enough to care about.