737582 - Remove redundant "gingerbread" and "honeycomb" themes and unused theme files

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

We have three themes, but there are no longer any meaningful differences between them; browser.css is literally identical in all three themes, while content.css differs in a few small ways in the "gingerbread" theme (and is identical for froyo and honeycomb).

The "gingerbread" theme is used on Android 2.3 and 4.0+ which account for the majority of our development devices, so the other themes are not really tested.  This duplication seems likely to lead to uncaught bugs in the less-used themes.

This patch simply removes the gingerbread and honeycomb theme directories.  I kept the "defines.inc" and "content.css" from the gingerbread theme because I expect they are better-tested than the froyo versions, but I merged in some changes that had been made to the froyo versions only.

This also removes some unused image files.

This patch shrinks the APK package by about 350KB.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 607659 [details] [diff] [review]
patch

Nice cleanup!

Comment 2

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1262bdd35f9d

Comment 3

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/1262bdd35f9d

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/68578d82198b