Remove redundant "gingerbread" and "honeycomb" themes and unused theme files

RESOLVED FIXED in Firefox 13

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mbrubeck, Assigned: mbrubeck)

Tracking

Trunk
Firefox 14
All
Android
Points:
---

Firefox Tracking Flags

(firefox13 fixed, firefox14 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 607659 [details] [diff] [review]
patch

We have three themes, but there are no longer any meaningful differences between them; browser.css is literally identical in all three themes, while content.css differs in a few small ways in the "gingerbread" theme (and is identical for froyo and honeycomb).

The "gingerbread" theme is used on Android 2.3 and 4.0+ which account for the majority of our development devices, so the other themes are not really tested.  This duplication seems likely to lead to uncaught bugs in the less-used themes.

This patch simply removes the gingerbread and honeycomb theme directories.  I kept the "defines.inc" and "content.css" from the gingerbread theme because I expect they are better-tested than the froyo versions, but I merged in some changes that had been made to the froyo versions only.

This also removes some unused image files.

This patch shrinks the APK package by about 350KB.
Attachment #607659 - Flags: review?(mark.finkle)
Blocks: 734797
Comment on attachment 607659 [details] [diff] [review]
patch

Nice cleanup!
Attachment #607659 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1262bdd35f9d
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/1262bdd35f9d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/releases/mozilla-aurora/rev/68578d82198b
status-firefox13: --- → fixed
status-firefox14: --- → fixed
You need to log in before you can comment on or make changes to this bug.