Closed Bug 737582 Opened 8 years ago Closed 8 years ago

Remove redundant "gingerbread" and "honeycomb" themes and unused theme files

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 --- fixed
firefox14 --- fixed

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
We have three themes, but there are no longer any meaningful differences between them; browser.css is literally identical in all three themes, while content.css differs in a few small ways in the "gingerbread" theme (and is identical for froyo and honeycomb).

The "gingerbread" theme is used on Android 2.3 and 4.0+ which account for the majority of our development devices, so the other themes are not really tested.  This duplication seems likely to lead to uncaught bugs in the less-used themes.

This patch simply removes the gingerbread and honeycomb theme directories.  I kept the "defines.inc" and "content.css" from the gingerbread theme because I expect they are better-tested than the froyo versions, but I merged in some changes that had been made to the froyo versions only.

This also removes some unused image files.

This patch shrinks the APK package by about 350KB.
Attachment #607659 - Flags: review?(mark.finkle)
Comment on attachment 607659 [details] [diff] [review]
patch

Nice cleanup!
Attachment #607659 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/1262bdd35f9d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.