734923 - xplat build: add rules to compile builtin.abc if possible

Status: RESOLVED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

If ASC is defined and builtin.as is newer than builtin.abc, then we should recompile builtin.as.

(Right?  Is there a reason not to do so?)

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Note that the existing rules often already rebuild builtin.abc as a *side-effect* of running the rules to build builtin.h and builtin.cpp; see Bug 632086, comment 2 (and various follow-on discussion of the trick being used there).

Intuitively one would think that all one needs to fix this is to (1.) add builtin.abc as one of the products generated by running builtin.py, and (2.) add a dependency on builtin.abc to "the right spot."  That's intuition; but my experimentation so far has not yielded a change that actually works (probably because (2.) is harder than it sounds).

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Ah, part of the mystery here is that generating shell_toplevel.abc actually needs generated/builtin.abc to preexist.  (The python script that does the generation even has a hard-coded path to the expectd builtin.abc, as well as various other hard-coded paths.)

I think I'll have an answer for this soon.

Comment 3

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: patch F v1: fix avm builtin and shell_toplevel abc generation

No rocket science here; just:

1. Generalize the rules that drive the python script invocations,

2. Add xxx.abc to the list of generated files we associated with builtin and shell

3. Add a dependency from the shell_toplevel.py invoking rule on the generated builtin.abc since it will be read in by asc (look in the source for shell_toplevel.py for that).

Comment 4

[Tamarin Bot]

changeset: 7341:fb16b7dd3564
user:      Felix Klock II <[e-mail]>
summary:   Bug 734923: [xplat] fix avm builtin.abc generation (r=fklockii).

http://hg.mozilla.org/tamarin-redux/rev/fb16b7dd3564

Comment 5

[Felix S. Klock II [:pnkfelix, :fklock]]

There's a dependency I had not known about: the exactgc.py script, which is called by both builtin-tracers.py and shell_toplevel-tracers.py, has a dependence on ../generated/builtin.abc and ../generated/shell_toplevel.abc.  This dependence is only exercised when the exactgc.as source needs to be recompiled, which is largely why I was ignorant of the problem until now.

Comment 6

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: patch G v1: add dep from tracer gen on abc presence

Fixes problem pointed out in comment 5.

Comment 7

[Tamarin Bot]

changeset: 7344:4ec35fd01e5d
user:      Felix Klock II <[e-mail]>
summary:   Bug 734923: [xplat] add dep from tarcer gen to builtin and shell abc (r=fklockii).

http://hg.mozilla.org/tamarin-redux/rev/4ec35fd01e5d