735127 - Fix "beause" spelling

Status: VERIFIED FIXED

(Core :: General, defect, P4)

Description

[Serge Gautherie (:sgautherie)]

Use "because".

"Found 3 matching lines in 3 files"
But leave /ipc alone.

Comment 1

[Pallani Kumaran]

Hello. I would like to work on this bug.

Comment 2

[Serge Gautherie (:sgautherie)]

Just do.

Comment 3

[Pallani Kumaran]

Attachment: Patch

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 605798 [details] [diff] [review]
Patch

Review of attachment 605798 [details] [diff] [review]:
-----------------------------------------------------------------

I marked this bug as meta because all 3 files are in different components which have (very) different review rules (iirc).
Please, split them into 2(-3) blocking bugs.

::: ipc/chromium/src/third_party/libevent/event.c
@@ +881,5 @@
>  	evutil_timersub(&base->event_tv, tv, &off);
>  
>  	/*
>  	 * We can modify the key element of the node without destroying
> +	 * the key, because we apply it to all in the right order.

That's correct, but I think chromium is external/upstream and should not be touched. (To be confirmed.)

::: security/nss/lib/pk11wrap/pk11auth.c
@@ +164,5 @@
>  	len = PORT_Strlen(pw);
>      }
>  
>      /*
> +     * If the token does't need a login, don't try to relogin because the

While here, fix "does't" too.

Comment 5

[Pallani Kumaran]

So there should be two different patch files? I do not know what "split them into 2(-3) blocking bugs" means.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to Pallani Kumaran from comment #5)

> So there should be two different patch files?

Yes.

> I do not know what "split them into 2(-3) blocking bugs" means.

It means: file 2 bugs, making them block this one, attach related patch to each.

Comment 7

[Pallani Kumaran]

Ok. I should do that for bug 735124 also?

Comment 8

[Serge Gautherie (:sgautherie)]

(In reply to Pallani Kumaran from comment #7)
> Ok. I should do that for bug 735124 also?

Answered there ;-)

Comment 9

[Serge Gautherie (:sgautherie)]

V.Fixed, per blocking bugs.