Fix "beause" spelling

VERIFIED FIXED in mozilla14

Status

()

Core
General
P4
trivial
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: Pallani Kumaran)

Tracking

Trunk
mozilla14
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Use "because".

"Found 3 matching lines in 3 files"
But leave /ipc alone.
Flags: in-testsuite-
(Assignee)

Comment 1

6 years ago
Hello. I would like to work on this bug.
(Reporter)

Comment 2

6 years ago
Just do.
(Assignee)

Comment 3

6 years ago
Created attachment 605798 [details] [diff] [review]
Patch
Attachment #605798 - Flags: review?(sgautherie.bz)
(Reporter)

Comment 4

6 years ago
Comment on attachment 605798 [details] [diff] [review]
Patch

Review of attachment 605798 [details] [diff] [review]:
-----------------------------------------------------------------

I marked this bug as meta because all 3 files are in different components which have (very) different review rules (iirc).
Please, split them into 2(-3) blocking bugs.

::: ipc/chromium/src/third_party/libevent/event.c
@@ +881,5 @@
>  	evutil_timersub(&base->event_tv, tv, &off);
>  
>  	/*
>  	 * We can modify the key element of the node without destroying
> +	 * the key, because we apply it to all in the right order.

That's correct, but I think chromium is external/upstream and should not be touched. (To be confirmed.)

::: security/nss/lib/pk11wrap/pk11auth.c
@@ +164,5 @@
>  	len = PORT_Strlen(pw);
>      }
>  
>      /*
> +     * If the token does't need a login, don't try to relogin because the

While here, fix "does't" too.
Attachment #605798 - Flags: review?(sgautherie.bz) → feedback-
(Assignee)

Comment 5

6 years ago
So there should be two different patch files? I do not know what "split them into 2(-3) blocking bugs" means.
(Reporter)

Comment 6

6 years ago
(In reply to Pallani Kumaran from comment #5)

> So there should be two different patch files?

Yes.

> I do not know what "split them into 2(-3) blocking bugs" means.

It means: file 2 bugs, making them block this one, attach related patch to each.
(Assignee)

Comment 7

6 years ago
Ok. I should do that for bug 735124 also?
(Reporter)

Comment 8

6 years ago
(In reply to Pallani Kumaran from comment #7)
> Ok. I should do that for bug 735124 also?

Answered there ;-)
Depends on: 735124
No longer depends on: 735124
(Reporter)

Updated

6 years ago
Depends on: 738160, 738161
(Reporter)

Comment 9

6 years ago
V.Fixed, per blocking bugs.
Assignee: nobody → pallanikumaran
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=sgautherie] [meta]
Target Milestone: --- → mozilla14
(Reporter)

Updated

6 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.