Closed Bug 735223 Opened 9 years ago Closed 9 years ago

Drop support for ancient NDKs

Categories

(Firefox Build System :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(2 files, 1 obsolete file)

We're not even sure we still build successfully with these, so I think we can get rid of the configure checks that make us support older NDKs.
Attached patch Drop support for ancient NDKs (obsolete) — Splinter Review
try: -b do -p android,android-xul,b2g -u none -t none
Attachment #623976 - Flags: review?(ted.mielczarek)
Comment on attachment 623976 [details] [diff] [review]
Drop support for ancient NDKs

Review of attachment 623976 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +247,2 @@
>      MOZ_ANDROID_LIBSTDCXX=1,
>      MOZ_ANDROID_LIBSTDCXX= )

Does this option actually work? If not, we should probably just drop it.
Attachment #623976 - Flags: review?(ted.mielczarek) → review+
(In reply to Ted Mielczarek [:ted] from comment #2)
> ::: configure.in
> @@ +247,2 @@
> >      MOZ_ANDROID_LIBSTDCXX=1,
> >      MOZ_ANDROID_LIBSTDCXX= )
> 
> Does this option actually work? If not, we should probably just drop it.

It appears it doesn't, and it went undectected for a while, seeing how it fails
(first failure is a failure to link because system android's libstdc++.so is picked before gnu libstdc++.a ; second failure is because std::wstring, used in ipc/chromium headers, is not defined unless _GLIBCXX_USE_WCHAR_T is defined, which requires -fshort-wchar, which we haven't been using for a while)

Also, considering the fact that libstdc++.a is, like stlport, only built for a limited set of things, and that its source is not in the ndk, like stlport, using it is likely to break depending on the arch build flags we use. All in all, stlport is the safest option.
Attachment #625355 - Flags: review?(ted.mielczarek)
Attachment #623976 - Attachment is obsolete: true
Same, but for nspr. This also fixes android-toolchain auto-detection for x86
<none>
Attachment #625356 - Flags: review?(ted.mielczarek)
Blocks: 756575
Attachment #625355 - Flags: review?(ted.mielczarek) → review+
Attachment #625356 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 625356 [details] [diff] [review]
Drop support for ancient NDKs (nspr part)

Checking in configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.328; previous revision: 1.327
done
Checking in configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.331; previous revision: 1.330
done
Target Milestone: --- → mozilla15
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.