735286 - Missing chat inverse icon

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[[:Aureliano Buendía]]

Attachment: bug-in-action

When move chat button near search icon (or if installed also calendar and task icon), TB display an empty square

Comment 1

[Andreas Nilsson (:andreasn)]

Attachment: adding missing graphics

I think this should do it.

Comment 2

[Andreas Nilsson (:andreasn)]

Attachment: patch (v2)

Apparently it was missing a little bit of css, and that made it look fuzzy.
Also made sure the regular toolbar graphics got cropped back to 18px high (was 19px for some reason).

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 609426 [details] [diff] [review]
patch (v2)

Review of attachment 609426 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: mail/themes/qute/mail/primaryToolbar-aero.css
@@ +261,4 @@
>      #button-goforward, #button-compact, #button-archive, #hdrArchiveButton,
>      #hdrReplyButton, #hdrReplyToSenderButton, #hdrReplyAllButton,
>      #hdrReplyOnlyButton, #hdrReplyListButton, #hdrForwardButton,
> +    #hdrTrashButton, #hdrJunkButton, #qfb-show-filter-bar, #button-chat

Hrm.  There's gotta be a better way of doing this rather than maintaining this big list of IDs.

:/

Maybe another class applied to all of our toolbar buttons?  I don't know.

Meh - just recording my objection to this long list here.  I'm not going to make you fix all of that stuff since it's unrelated to the patch.  :)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch (v3)

Un-bitrotting this patch, and transferring my r+.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 614466 [details] [diff] [review]
Patch (v3)

ui-r=me, based on the screenshot in IRC.

Thanks,
Blake.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/9438b3c98497