Missing chat inverse icon

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Theme
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Aureliano, Assigned: andreasn)

Tracking

({polish})

unspecified
Thunderbird 14.0
x86
Windows 7
polish

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

5 years ago
Created attachment 605430 [details]
bug-in-action

When move chat button near search icon (or if installed also calendar and task icon), TB display an empty square
(Assignee)

Updated

5 years ago
Assignee: nobody → nisses.mail
(Assignee)

Comment 1

5 years ago
Created attachment 609391 [details] [diff] [review]
adding missing graphics

I think this should do it.
(Assignee)

Comment 2

5 years ago
Created attachment 609426 [details] [diff] [review]
patch (v2)

Apparently it was missing a little bit of css, and that made it look fuzzy.
Also made sure the regular toolbar graphics got cropped back to 18px high (was 19px for some reason).
Attachment #609391 - Attachment is obsolete: true
Attachment #609426 - Flags: ui-review?(bwinton)
Attachment #609426 - Flags: review?(mconley)
Comment on attachment 609426 [details] [diff] [review]
patch (v2)

Review of attachment 609426 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: mail/themes/qute/mail/primaryToolbar-aero.css
@@ +261,4 @@
>      #button-goforward, #button-compact, #button-archive, #hdrArchiveButton,
>      #hdrReplyButton, #hdrReplyToSenderButton, #hdrReplyAllButton,
>      #hdrReplyOnlyButton, #hdrReplyListButton, #hdrForwardButton,
> +    #hdrTrashButton, #hdrJunkButton, #qfb-show-filter-bar, #button-chat

Hrm.  There's gotta be a better way of doing this rather than maintaining this big list of IDs.

:/

Maybe another class applied to all of our toolbar buttons?  I don't know.

Meh - just recording my objection to this long list here.  I'm not going to make you fix all of that stuff since it's unrelated to the patch.  :)
Attachment #609426 - Flags: review?(mconley) → review+
Created attachment 614466 [details] [diff] [review]
Patch (v3)

Un-bitrotting this patch, and transferring my r+.
Attachment #609426 - Attachment is obsolete: true
Attachment #614466 - Flags: review+
Attachment #609426 - Flags: ui-review?(bwinton)
Comment on attachment 614466 [details] [diff] [review]
Patch (v3)

ui-r=me, based on the screenshot in IRC.

Thanks,
Blake.
Attachment #614466 - Flags: ui-review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/9438b3c98497
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in before you can comment on or make changes to this bug.