Last Comment Bug 735380 - Signature switching in plaintext compose doesn't work
: Signature switching in plaintext compose doesn't work
Status: RESOLVED FIXED
: regression
Product: Thunderbird
Classification: Client Software
Component: Message Compose Window (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: Thunderbird 13.0
Assigned To: Mike Conley (:mconley)
:
:
Mentors:
Depends on: 765803
Blocks: BigFiles
  Show dependency treegraph
 
Reported: 2012-03-13 12:20 PDT by Mike Conley (:mconley)
Modified: 2012-07-13 10:20 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1 (11.21 KB, patch)
2012-03-13 12:23 PDT, Mike Conley (:mconley)
no flags Details | Diff | Splinter Review
Patch v2 (11.37 KB, patch)
2012-03-13 12:26 PDT, Mike Conley (:mconley)
mozilla: review+
Details | Diff | Splinter Review
Patch v3 (carrying over r+ from bienvenu) (11.29 KB, patch)
2012-03-13 13:56 PDT, Mike Conley (:mconley)
no flags Details | Diff | Splinter Review

Description Mike Conley (:mconley) 2012-03-13 12:20:12 PDT
Fallout from bug 698925.

STR:

1)  Have two accounts, each with a distinct signature
2)  Open a compose window in plaintext mode
3)  The compose window should have one account's signature in the body of the message
4)  Switch the "From" dropdown to the other account

What happens?

The signature does not change.

What's expected?

The signature should be updated to match the newly selected account.

This is also causing a permanent orange on comm-central.
Comment 1 Mike Conley (:mconley) 2012-03-13 12:23:43 PDT
Created attachment 605481 [details] [diff] [review]
Patch v1

David:

Am I on the right track?  I felt a bit out of my depth inside nsMsgCompose.cpp.  Did I miss any edge cases?

The compose XPCShell tests seem to pass, and the composition Mozmill tests now all pass with this patch.

-Mike
Comment 2 Mike Conley (:mconley) 2012-03-13 12:26:10 PDT
Created attachment 605483 [details] [diff] [review]
Patch v2

Forgot to fix some whitespace issues.
Comment 3 David :Bienvenu 2012-03-13 13:52:53 PDT
Comment on attachment 605483 [details] [diff] [review]
Patch v2

this tests correctly for me, so r=me, modulo the extra blank line before the sig in plain text mode.
Comment 4 Mike Conley (:mconley) 2012-03-13 13:56:32 PDT
Created attachment 605528 [details] [diff] [review]
Patch v3 (carrying over r+ from bienvenu)

Thanks!  Axing extra linebreaks.
Comment 5 Mike Conley (:mconley) 2012-03-13 13:59:21 PDT
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/3eea95c47748

Note You need to log in before you can comment on or make changes to this bug.