Closed Bug 735524 Opened 8 years ago Closed 8 years ago
remove migration assistant which relates to tb2-tb3 differences
STR: 1. Open a new compose window by clicking the Compose button in the toolbar. 2. Then click Help > Migration wizard. 3. You find out that there's a blank window opening, as opposed to when the migration wizard is opened using the Main window. Screencast: http://screencast.com/t/4LJnemrB NB: I'm sorry for all the German in the screencast :P
Timestamp: 3/14/12 3:39:13 PM Error: aParentWin.gFolderTreeView is undefined Source File: chrome://messenger/content/featureConfigurator.js Line: 109
(In reply to Ludovic Hirlimann [:Usul] from comment #1) > Timestamp: 3/14/12 3:39:13 PM > Error: aParentWin.gFolderTreeView is undefined > Source File: chrome://messenger/content/featureConfigurator.js > Line: 109 From what I can see aParentWin references the open Compose Mail window, not the Thunderbird main window. In the TB main window, there's a gFolderTreeView, but not in the Compose mail window. That's why that check fails. Maybe I can fix it myself.
You can probably do something like this in fc_init - http://mxr.mozilla.org/comm-central/source/mail/base/content/featureConfigurator.js#102 if (!aParentWin.gFolderTreeView) aParentWin = Services.wm.getMostRecentWindow("mail:3pane"); However... with no 3pane open things will get more complicated. Did i hear there were plans to get rid of the migration wiz, btw? Blake?
Yeah, I think there are plans, but we haven't gotten around to it yet.
Ok, let's hijack this bug for the removal.
Assignee: nobody → mkmelin+mozilla
Summary: Migration wizard window is blank when opened from a compose window → remove migration assistant which relates to tb2-tb3 differences
Almost seems like a shame, but i think it's played it's role.
Attachment #623240 - Flags: review?(bugmail) → review?(bwinton)
Comment on attachment 623240 [details] [diff] [review] proposed fix Yep, looks good to me, although I'll be a little sad to see it go… :) ui-r=me, r=me.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
I've landed a build bustage fix for this - http://hg.mozilla.org/comm-central/rev/499441818d84 Note that there's also some mozmill cruft that seems left over - http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/shared-modules/test-window-helpers.js#1257
Thx David! (Must have missed a qrefresh as i'm sure i grepped for those strings.) This removes the mozmill cruft
Attachment #624808 - Flags: review?(dbienvenu)
Comment on attachment 624808 [details] [diff] [review] proposed fix followup thx for the patch, r=me; it would be nice if you restore the comma after the next to last } so that if anyone adds something to that code, they won't get bit by the missing ','.
Attachment #624808 - Flags: review?(dbienvenu) → review+
You need to log in before you can comment on or make changes to this bug.