remove migration assistant which relates to tb2-tb3 differences

VERIFIED FIXED in Thunderbird 15.0

Status

Thunderbird
Migration
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: Tobbi, Assigned: Magnus Melin)

Tracking

10 Branch
Thunderbird 15.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
STR:
1. Open a new compose window by clicking the Compose button in the toolbar. 
2. Then click Help > Migration wizard. 
3. You find out that there's a blank window opening, as opposed to when the migration wizard is opened using the Main window.

Screencast:
http://screencast.com/t/4LJnemrB

NB: I'm sorry for all the German in the screencast :P
Timestamp: 3/14/12 3:39:13 PM
Error: aParentWin.gFolderTreeView is undefined
Source File: chrome://messenger/content/featureConfigurator.js
Line: 109
(Reporter)

Comment 2

5 years ago
(In reply to Ludovic Hirlimann [:Usul] from comment #1)
> Timestamp: 3/14/12 3:39:13 PM
> Error: aParentWin.gFolderTreeView is undefined
> Source File: chrome://messenger/content/featureConfigurator.js
> Line: 109

From what I can see aParentWin references the open Compose Mail window, not the Thunderbird main window. In the TB main window, there's a gFolderTreeView, but not in the Compose mail window. That's why that check fails. Maybe I can fix it myself.
(Assignee)

Comment 3

5 years ago
You can probably do something like this in fc_init - http://mxr.mozilla.org/comm-central/source/mail/base/content/featureConfigurator.js#102
if (!aParentWin.gFolderTreeView) 
  aParentWin = Services.wm.getMostRecentWindow("mail:3pane");

However... with no 3pane open things will get more complicated.

Did i hear there were plans to get rid of the migration wiz, btw? Blake?
Yeah, I think there are plans, but we haven't gotten around to it yet.
(Assignee)

Comment 5

5 years ago
Ok, let's hijack this bug for the removal.
Assignee: nobody → mkmelin+mozilla
Summary: Migration wizard window is blank when opened from a compose window → remove migration assistant which relates to tb2-tb3 differences
(Assignee)

Comment 6

5 years ago
Created attachment 623240 [details] [diff] [review]
proposed fix

Almost seems like a shame, but i think it's played it's role.
Attachment #623240 - Flags: ui-review?(bwinton)
Attachment #623240 - Flags: review?(bugmail)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Attachment #623240 - Flags: review?(bugmail) → review?(bwinton)
Comment on attachment 623240 [details] [diff] [review]
proposed fix

Yep, looks good to me, although I'll be a little sad to see it go…  :)  ui-r=me, r=me.
Attachment #623240 - Flags: ui-review?(bwinton)
Attachment #623240 - Flags: ui-review+
Attachment #623240 - Flags: review?(bwinton)
Attachment #623240 - Flags: review+
(Assignee)

Comment 8

5 years ago
http://hg.mozilla.org/comm-central/rev/75dec57445dc -> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
(Assignee)

Updated

5 years ago
Severity: major → normal

Comment 9

5 years ago
I've landed a build bustage fix for this - http://hg.mozilla.org/comm-central/rev/499441818d84

Note that there's also some mozmill cruft that seems left over - http://mxr.mozilla.org/comm-central/source/mail/test/mozmill/shared-modules/test-window-helpers.js#1257
(Assignee)

Comment 10

5 years ago
Created attachment 624808 [details] [diff] [review]
proposed fix followup

Thx David! (Must have missed a qrefresh as i'm sure i grepped for those strings.)

This removes the mozmill cruft
Attachment #624808 - Flags: review?(dbienvenu)

Comment 11

5 years ago
Comment on attachment 624808 [details] [diff] [review]
proposed fix followup

thx for the patch, r=me; it would be nice if you restore the comma after the next to last } so that if anyone adds something to that code, they won't get bit by the missing ','.
Attachment #624808 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 12

5 years ago
http://hg.mozilla.org/comm-central/rev/c610c1d09616
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.