Last Comment Bug 735564 - about:newtab has on-hover UI that doesn't work well with touch-screens
: about:newtab has on-hover UI that doesn't work well with touch-screens
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: unspecified
: x86 Windows 8
-- normal (vote)
: Firefox 14
Assigned To: Blair McBride [:Unfocused] (UNAVAILABLE)
Depends on:
Blocks: 1055531 455553
  Show dependency treegraph
Reported: 2012-03-13 20:59 PDT by Blair McBride [:Unfocused] (UNAVAILABLE)
Modified: 2014-08-19 11:18 PDT (History)
7 users (show)
blair: in‑testsuite-
blair: in‑litmus-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch v1 (914 bytes, patch)
2012-03-15 04:30 PDT, Blair McBride [:Unfocused] (UNAVAILABLE)
ttaubert: review+
lukasblakk+bugs: approval‑mozilla‑aurora+
Details | Diff | Splinter Review

Description User image Blair McBride [:Unfocused] (UNAVAILABLE) 2012-03-13 20:59:29 PDT
Running a Windows 8 tablet - touch-screen, no mouse. The new tab page has on-hover UI (pin/unpin, forget) that doesn't work well with a touch-screen.

Current workaround is to start moving a thumbnail, drop it in it's original place, then hit one of the buttons.
Comment 1 User image Jared Wein [:jaws] (please needinfo? me) 2012-03-15 03:02:31 PDT
Might be able to include a CSS media type for handheld which makes the buttons always visible?

@media handheld {
  .newtab-control {
    opacity: 1;

in /browser/base/content/newtab/newTab.css
Comment 2 User image Tim Taubert [:ttaubert] 2012-03-15 03:08:23 PDT
That sounds like a good idea to me. I unfortunately don't have a handheld that runs default Firefox. Anyone willing to test this? Should I kick off a try build?
Comment 3 User image Dão Gottwald [:dao] 2012-03-15 03:38:52 PDT
A tablet isn't a handheld. You want -moz-touch-enabled.
Comment 4 User image Blair McBride [:Unfocused] (UNAVAILABLE) 2012-03-15 04:30:57 PDT
Created attachment 606161 [details] [diff] [review]
Patch v1

This works.
Comment 5 User image Tim Taubert [:ttaubert] 2012-03-15 04:34:50 PDT
Comment on attachment 606161 [details] [diff] [review]
Patch v1

Review of attachment 606161 [details] [diff] [review]:

Nice, thank you!
Comment 6 User image Blair McBride [:Unfocused] (UNAVAILABLE) 2012-03-20 21:43:10 PDT
Comment 7 User image Tim Taubert [:ttaubert] 2012-03-20 22:03:57 PDT
Comment on attachment 606161 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Regression caused by (bug #): new newtab layout
User impact if declined: thumbnail controls unreachable on touch devices running desktop firefox
Risk to taking this patch (and alternatives if risky): small css-only fix, virtually no risk
String changes made by this patch: none
Comment 8 User image Lukas Blakk [:lsblakk] use ?needinfo 2012-03-21 13:58:21 PDT
Comment on attachment 606161 [details] [diff] [review]
Patch v1

[Triage Comment]
Looks good, low risk and positive user experience impact.
Comment 9 User image Marco Bonardo [::mak] 2012-03-21 15:54:53 PDT
Comment 10 User image Tim Taubert [:ttaubert] 2012-03-22 01:42:57 PDT
Comment 11 User image juan becerra [:juanb] 2012-05-30 12:23:36 PDT
Verified on Fx13b6 20120528154913 on a touch screen machine with Windows 8 Consumer Preview. Previous builds do not show the pin/remove icons, but they always show on Fx13b6.
Comment 12 User image Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2012-05-30 14:54:26 PDT
Thanks Juan.

Note You need to log in before you can comment on or make changes to this bug.