735618 - Don't try to package MSVC dlls if WIN32_REDIST_DIR is not set, in SeaMonkey

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P2)

Description

[Philip Chee]

[chatzilla]
bin/distribution/extensions/{59c81df5-4b7a-477b-912d-4e0fdf64e5f2}.xpi
[venkman]
bin/distribution/extensions/{f13b157f-b174-47e7-a34d-4815ddfdfeb8}.xpi
[inspector]
bin/distribution/extensions/[e-mail]
[debugqa]
bin/distribution/extensions/[e-mail]
Error: found error(s) while packaging, see above for details.
c:\t1\hg\comm-central\mozilla\toolkit\mozapps\installer\packager.mk:758:0: command '/bin/sh /c/t1/hg/comm-central/mozilla/build/msys-perl-wrapper -Ic:/t1/hg/comm-central/mozilla/toolkit/mozapps/installer -e 'use Packager; Packager::Copy( "c:/t1/hg/objdir-sm/suite/installer/../../mozilla/dist", "c:/t1/hg/objdir-sm/suite/installer/../../mozilla/dist/seamonkey", "package-manifest", "dos", 1,1, 0, 1);'' failed, return code 9
c:\t1\hg\objdir-sm\suite\installer\windows\Makefile:83:0: command 'c:/DEV/mozilla-build/python/python.exe c:/t1/hg/comm-central/mozilla/build/pymake/pymake/../make.py -C .. installer-stage' failed, return code 2
c:\t1\hg\objdir-sm\suite\installer\Makefile:189:0: command 'c:/DEV/mozilla-build/python/python.exe c:/t1/hg/comm-central/mozilla/build/pymake/pymake/../make.py -C windows' failed, return code 2
c:\t1\hg\comm-central\suite\build.mk:76:0: command 'c:/DEV/mozilla-build/python/python.exe c:/t1/hg/comm-central/mozilla/build/pymake/pymake/../make.py -C suite/installer installer' failed, return code 2

Manually turning off MOZ_PKG_FATAL_WARNINGS and I see:

Warning: package error or possible missing or unnecessary file: bin/Microsoft.VC90.CRT.manifest (package-manifest, 52).
Warning: package error or possible missing or unnecessary file: bin/msvcm90.dll (package-manifest, 53).
Warning: package error or possible missing or unnecessary file: bin/msvcp90.dll (package-manifest, 54).
Warning: package error or possible missing or unnecessary file: bin/msvcr90.dll (package-manifest, 55).

According to Callek:

Callek>	RattyAway: ooo hrm, please open a new bug for that, mark it crit, and assign it to serge (ask him to fix it), but CC me
if he doesn't in the next day, I'll tackle it, should be easy the idea is to make it so that the win32_redist_dir need not be set for local devs, imo

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Stop trying to package MSVC dlls when WIN32_REDIST_DIR isn't set

Comment 2

[Philip Chee]

Comment on attachment 605887 [details] [diff] [review]
(Av1) Stop trying to package MSVC dlls when WIN32_REDIST_DIR isn't set

Works for me locally.

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 605887 [details] [diff] [review]
(Av1) Stop trying to package MSVC dlls when WIN32_REDIST_DIR isn't set

Review of attachment 605887 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the caveat that I want this to match the Firefox solution if a review comes in with different nits there. But this can land now. (you can port nits from that bug to c-c for suite with rs+=me if you attach a copy of it here)

approval+ for this patch (not any extra m-c based nits) if you intend to land the "package warnings as errors" patch on aurora

Comment 4

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) Stop trying to package MSVC dlls when WIN32_REDIST_DIR isn't set, Sort '[xpcom]' files

Av1, enhanced and sync'ed with Firefox.

Comment 5

[Philip Chee]

Firefox patch backed out.

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Av3) Stop trying to package MSVC dlls when WIN32_REDIST_DIR isn't set, Sort '[xpcom]' files [Checked in: Comment 8 & 10 & 9]

Av2, sync'ed with Firefox.

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 610647 [details] [diff] [review]
(Av3) Stop trying to package MSVC dlls when WIN32_REDIST_DIR isn't set, Sort '[xpcom]' files
[Checked in: Comment 8 & 10 & 9]

rs+ assuming the meaningful change matches Firefox

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 610647 [details] [diff] [review]
(Av3) Stop trying to package MSVC dlls when WIN32_REDIST_DIR isn't set, Sort '[xpcom]' files
[Checked in: Comment 8 & 10 & 9]

http://hg.mozilla.org/comm-central/rev/ea634cabcdbd

Comment 9

[Justin Wood (:Callek)]

[on beta] Had to account for context changes in removed-files.in should be set though
[beta] http://hg.mozilla.org/releases/comm-beta/rev/df26107591e1

Comment 10

[Justin Wood (:Callek)]

http://hg.mozilla.org/releases/comm-aurora/rev/84fc16ef86e2

Comment 11

[Serge Gautherie (:sgautherie)]

V.Fixed, per still succeeding Windows builds.
seamonkey2.10 and seamonkey2.9: verified, per still succeeding Windows builds.