735725 - Properly display multiple line annotations in the source editor

Status: RESOLVED INVALID

(DevTools :: Source Editor, defect, P2)

Description

[Mihai Sucan [:msucan]]

In bug 731721 comment 10 it is pointed out that the new "current step" line indicator is not displayed when a breakpoint is also set on the same line. We need to add an icon that is displayed when multiple annotations are on the same line. This work should probably go together with the work in bug 721752 - it makes sense to show a tooltip of all the annotations on the given line when an icon of "multiple annotations" is displayed.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Moving to Source Editor component.

Filter on CHELICERAE.

Comment 2

[Mihai Sucan [:msucan]]

Several people have asked for improved handling of multiple annotations on the same line. Breakpoint + currentDebuggerLocation and so on.

Increasing priority.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I noticed that Orion's overview-ruler (apart from the annotation ruler) also doesn't display executin line (debugLocation) in case there is a breakpoint on the line too.

The problem is that the DIV representing the debug location (located within "ruler overview" class element) is not created if there is already one for the breakpoint.

Breakpoint has "annotationOverview breakpoint"
Execution line "annotationOverview debugLocation"

I believe that seeing the execution line is more important for the user than a breakpoint at the time when stepping.

Is is possible to change/customize the priority so, it's the "debugLocation" which is always there?

Honza

Comment 4

[Mihai Sucan [:msucan]]

Thank you Honza. Once I get to implement a fix for this bug I will also look into the overview ruler.

Comment 5

[Anton Kovalyov (:anton)]

I think this is not a problem with the CodeMirror version of SourceEditor? I just used line classes and multiple backgrounds.