788165 - Breakpoint arrow does not change to green when the debugger breaks on that line.

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Girish Sharma [:Optimizer]]

Attachment: Blue icon on a broken line

STR are simple.

1. Open any page (tested on more than 10)
2. Open debugger.
3. Select a script and create a breakpoint that is likely to hit.
4. Refresh the page.
5. Control stops on the set line, but the blue circular icon does not change to green pointed arrow.
6. Clicking any other entry from the stacklist changes the highlighted line and also the pointer to green.

Latest Nightly build (3rd Sep.) Windows 7 x64. Aero.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Bug 762979 should fix this.

Comment 2

[Mihai Sucan [:msucan]]

Known issue. See bug 735725. Thanks for your report Girish!

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

We'll probably get to bug 735725 before bug 762979.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: WIP Patch

Mihai, this gets the debugLocation icon placed on top of the breakpoint. I made it a little smaller in this case so that the user can still see the breakpoint icon behind it.

I am not sure how annotationHTML.task is used, so I didn't change that line, but it would be easy to make it match the debugLocation and breakpoint changes.

Does this look good enough to you?

Comment 5

[Mihai Sucan [:msucan]]

Comment on attachment 708225 [details] [diff] [review]
WIP Patch

This looks good - thank you!

.task is used for lines with TODO - you can test it.

Please update the patch for Linux and Macs.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

I give up on trying to get .task to work with TODO. I tried //TODO, // todo, //XXX, // ToDo but none of them got any special annotation.

Either way, I made the changes assuming that it would work if I knew what I was doing :)

Comment 7

[Mihai Sucan [:msucan]]

(In reply to Jared Wein [:jaws] from comment #6)
> Created attachment 709922 [details] [diff] [review]
> Patch
> 
> I give up on trying to get .task to work with TODO. I tried //TODO, // todo,
> //XXX, // ToDo but none of them got any special annotation.

Hmm, maybe I didn't enable this Orion feature.

> Either way, I made the changes assuming that it would work if I knew what I
> was doing :)

Thank you!

Comment 8

[Mihai Sucan [:msucan]]

Comment on attachment 709922 [details] [diff] [review]
Patch

Thanks for the patch!

Comment 9

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/d426073720eb

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/d426073720eb