735747 - Form autocomplete doesn't trigger oninput event

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, steps to reproduce:
- Make sure you have some autocomplete suggestions available, if you haven't then put some text inside the input and press submit
- Then make sure the form autocomplete popups comes up, tap on one of the suggested values.

Expected result:
Input event fired, which shows up as text under the text input

Actual result:
No input event fired, nothing is showing up under the text input

Tested on current trunk build, Android 4.0.2, Samsung Galaxy Nexus.

Comment 1

[:Margaret Leibovic]

To clarify, are you saying that when you tap a suggestion, the input doesn't get filled with the suggestion. This could be a problem with element.value, likely related to bug 735469.

Comment 2

[Martijn Wargers (dead)]

No, the input does get filled with the suggestion, however, underneath the input, some text should appear like "event fired: input - input value: a" (if 'a' was the autocomplete suggestion that was tapped upon). That is the indication that an input event was fired, which currently doesn't seem to happen when autocomplete fills in the text in the input.

Btw, I noticed that the input event is fired twice, while typing a character with the virtual keyboard, so I filed bug 735806 for that.

Comment 3

[:Margaret Leibovic]

Oh, I see. Does XUL fennec do this? I'm not sure what the expectation should be.

Comment 4

[Martijn Wargers (dead)]

No, XUL Fennec doesn't seem to do this either, however desktop Firefox does this.
According to the spec, this event should fire when the user causes the input value to change, see: http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#event-input-input

Comment 5

[:Margaret Leibovic]

Attachment: patch

I really wonder why we chose to do it this way - I guess we were just copying XUL fennec? This is the way desktop Firefox does it, and this method does exactly what we want:
http://mxr.mozilla.org/mozilla-central/source/dom/interfaces/core/nsIDOMNSEditableElement.idl#56

Comment 6

[:Margaret Leibovic]

Attachment: patch

We can also get rid of the .blur() hack in there (I confirmed that autocomplete works fine with that gone).

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 615440 [details] [diff] [review]
patch

You are OK to land this patch

Comment 8

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b16ed4c13f5b

Comment 9

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/b16ed4c13f5b

Comment 10

[Cristian Nicolae (:xti)]

Everything works as expected on the latest Nightly and Aurora builds. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-28)
Firefox 14.0a2 (2012-05-28)

Device: Galaxy Nexus
OS: Android 4.0.2