735970 - Add xpcshell tests for version upgrades and version downgrades inside updater code

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

We should sign a MAR with version number 0 to test version downgrades that should not work. We should get a status code of 23 in this case.

We should sign a MAR with version number * to test version upgrades that should work.  We should get a status code of 0 in this case.

The tests should run for the updater instead of the service since the updater is easier for people to test in a larger number of environments.

This can only land after:
Bug 735969 - Revert the disable version downgrade check workaround

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

I was originally thinking these tests needed to be in the libmar test suite but the code for these checks are in updater so the tests need to go there.

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 610805 [details] [diff] [review]
Patch v1.

Looks good overall but could you:
1. give a descriptive name to the test files.
2. keep the tests alphabetical in order in the xpcshell ini file so the names with the numbers determine the order they run. It used to be they just ran in that order before the xpcshell ini files were added.

Comment 3

[Brian R. Bondy [:bbondy]]

Will do, thanks for the review.

Comment 4

[Brian R. Bondy [:bbondy]]

Attachment: Patch v2.

Implemented review comments

Comment 5

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/mozilla-central/rev/a020473c62f9