Closed Bug 735998 Opened 9 years ago Closed 9 years ago

HTML entities in the latest tweet under "@<twitter-account> timeline" should be resolved to Unicode characters

Categories

(Thunderbird :: Instant Messaging, defect)

defect
Not set
normal

Tracking

(thunderbird15 fixed)

RESOLVED FIXED
Thunderbird 16.0
Tracking Status
thunderbird15 --- fixed

People

(Reporter: masayuki, Assigned: florian)

Details

Attachments

(1 file)

The latest tweet in the timeline is shown at the top-right of the chat tab (under "@<twitter-account> timeline").

However, it doesn't resolve HTML entities such as &gt; to Unicode characters. I.e., "foo > bar" is shown as "foo &gt; bar" there.
It seems we forgot to unescape the HTML entities before setting the topic when sending a tweet.
OS: Windows 7 → All
Hardware: x86_64 → All
Attached patch PatchSplinter Review
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #632268 - Flags: review?(clokep)
Comment on attachment 632268 [details] [diff] [review]
Patch

This looks fine, did we verify that we should be sending the entities to Twitter? (I vaguely recall we're supposed to, but just wanted to check!)
Attachment #632268 - Flags: review?(clokep) → review+
https://hg.mozilla.org/comm-central/rev/f00ab2e3c12d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
Comment on attachment 632268 [details] [diff] [review]
Patch

[Approval Request Comment]
Simple fix for a quite visible bug when using twitter.
Attachment #632268 - Flags: approval-comm-aurora?
Attachment #632268 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.