736005 - java.lang.IllegalArgumentException: Make sure the SurfaceView or associated SurfaceHolder has a valid Surface at com.google.android.gles_jni.EGLImpl._eglCreateWindowSurface(Native Method)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Scoobidiver (away)]

It first appeared in 13.0a1/20120310. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=08809a43e082&tochange=3fdc1c14a8ce
It's likely a regression from bug 734081.

java.lang.IllegalArgumentException: Make sure the SurfaceView or associated SurfaceHolder has a valid Surface
	at com.google.android.gles_jni.EGLImpl._eglCreateWindowSurface(Native Method)
	at com.google.android.gles_jni.EGLImpl.eglCreateWindowSurface(EGLImpl.java:87)
	at android.opengl.GLSurfaceView$DefaultWindowSurfaceFactory.createWindowSurface(GLSurfaceView.java:718)
	at android.opengl.GLSurfaceView$EglHelper.createSurface(GLSurfaceView.java:975)
	at android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1335)
	at android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1118)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalArgumentException%3A%20Make%20sure%20the%20SurfaceView%20or%20associated%20SurfaceHolder%20has%20a%20valid%20Surface%20at%20com.google.android.gles_jni.EGLImpl._eglCreateWindowSurface%28Native%20Method%29

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

mwu, can you investigate this as a regression from bug 734081?

Comment 2

[Michael Wu [:mwu]]

Attachment: Put fallback back on Android

Sounds like some drivers don't always support 16 bit, despite the GLSurfaceView documentation that seems to imply 16 bit is always available.

I'll have to put in a more descriptive comment for the fallback code.

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 612859 [details] [diff] [review]
Put fallback back on Android

Sigh.

Yes, please document the "+#ifdef MOZ_WIDGET_ANDROID" hackery.

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

r=me with that.

Comment 5

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7936634f5fe3

Comment 6

[Michael Wu [:mwu]]

oops.

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/7936634f5fe3

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 612859 [details] [diff] [review]
Put fallback back on Android

Review of attachment 612859 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +1504,5 @@
> +        }
> +#endif
> +        return false;
> +    } else {
> +        return true;

Style guide disallows this...