Closed Bug 736005 Opened 10 years ago Closed 10 years ago

java.lang.IllegalArgumentException: Make sure the SurfaceView or associated SurfaceHolder has a valid Surface at com.google.android.gles_jni.EGLImpl._eglCreateWindowSurface(Native Method)

Categories

(Firefox for Android Graveyard :: General, defect)

13 Branch
ARM
Android
defect
Not set
critical

Tracking

(firefox13 affected, blocking-fennec1.0 -)

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 --- affected
blocking-fennec1.0 --- -

People

(Reporter: scoobidiver, Assigned: mwu)

References

Details

(Keywords: crash, regression, Whiteboard: [native-crash][gfx][startupcrash])

Crash Data

Attachments

(1 file)

It first appeared in 13.0a1/20120310. The regression range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=08809a43e082&tochange=3fdc1c14a8ce
It's likely a regression from bug 734081.

java.lang.IllegalArgumentException: Make sure the SurfaceView or associated SurfaceHolder has a valid Surface
	at com.google.android.gles_jni.EGLImpl._eglCreateWindowSurface(Native Method)
	at com.google.android.gles_jni.EGLImpl.eglCreateWindowSurface(EGLImpl.java:87)
	at android.opengl.GLSurfaceView$DefaultWindowSurfaceFactory.createWindowSurface(GLSurfaceView.java:718)
	at android.opengl.GLSurfaceView$EglHelper.createSurface(GLSurfaceView.java:975)
	at android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1335)
	at android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1118)

More reports at:
https://crash-stats.mozilla.com/report/list?signature=java.lang.IllegalArgumentException%3A%20Make%20sure%20the%20SurfaceView%20or%20associated%20SurfaceHolder%20has%20a%20valid%20Surface%20at%20com.google.android.gles_jni.EGLImpl._eglCreateWindowSurface%28Native%20Method%29
Assignee: nobody → blassey.bugs
mwu, can you investigate this as a regression from bug 734081?
Assignee: blassey.bugs → mwu
blocking-fennec1.0: --- → -
Whiteboard: [native-crash] → [native-crash][gfx][startupcrash]
Sounds like some drivers don't always support 16 bit, despite the GLSurfaceView documentation that seems to imply 16 bit is always available.

I'll have to put in a more descriptive comment for the fallback code.
Attachment #612859 - Flags: review?(jones.chris.g)
Comment on attachment 612859 [details] [diff] [review]
Put fallback back on Android

Sigh.

Yes, please document the "+#ifdef MOZ_WIDGET_ANDROID" hackery.
Attachment #612859 - Flags: review?(jones.chris.g) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/7936634f5fe3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
oops.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/7936634f5fe3
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Comment on attachment 612859 [details] [diff] [review]
Put fallback back on Android

Review of attachment 612859 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextProviderEGL.cpp
@@ +1504,5 @@
> +        }
> +#endif
> +        return false;
> +    } else {
> +        return true;

Style guide disallows this...
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.