"Copy rule" with some text selected copies that text additionally

RESOLVED WORKSFORME

Status

()

Firefox
Developer Tools: Inspector
P1
normal
RESOLVED WORKSFORME
6 years ago
5 years ago

People

(Reporter: Rimas Kudelis, Assigned: miker)

Tracking

unspecified
Firefox 14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ruleview])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
STR:
1. Open style inspector's Rules tab
2. Right-click on the name or value of any property. At least in Linux, the name/value will be selected and the context menu shown
3. Click on "Copy rule"
4. Paste the text elsewhere.

Here's an example of what I get when pasting:

body {
    font: 14px/1.428 "Lucida Grande","Lucida Sans Unicode",Lucida,Arial,Helvetica,sans-serif;
    14px/1.428 "Lucida Grande","Lucida Sans Unicode",Lucida,Arial,Helvetica,sans-serifcolor: rgb(51, 51, 51);
}

As you can see, the value was selected, because it gets pasted twice. This does happen with the latest nightly.

Comment 1

6 years ago
I think it's in Aurora too.
Priority: -- → P1
Whiteboard: [ruleview]
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
Created attachment 606211 [details] [diff] [review]
Patch

I have tried to prevent the right mouse button from focusing the property editor but the context menu forces the element to focus in order to get the popupNode. Not showing the context menu would be confusing so allowing the editor to open, copy the rule and trim the cruft method is the best work around.

I don't think this is important enough to get into Aurora though.
Attachment #606211 - Flags: review?(paul)

Comment 3

6 years ago
Comment on attachment 606211 [details] [diff] [review]
Patch

I think it's quite important as it just breaks the "copy rule" feature. Let's get that in Aurora.
Attachment #606211 - Flags: review?(paul) → review+

Comment 4

6 years ago
Once this has landed, we should request for aurora approval.
Whiteboard: [ruleview] → [ruleview][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/d7b1fd262d91
Whiteboard: [ruleview][land-in-fx-team] → [ruleview][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/d7b1fd262d91
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [ruleview][fixed-in-fx-team] → [ruleview][fixed-in-fx-team
Target Milestone: --- → Firefox 14

Comment 7

6 years ago
This is still broken.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [ruleview][fixed-in-fx-team → [ruleview]

Updated

6 years ago
Blocks: 740606
Status: REOPENED → ASSIGNED
Interesting, I don't see how it was possible for this to happen. I have rewritten the "Copy Rule" code in bug 740603 so hopefully this is fixed.
No longer blocks: 740606
Depends on: 740603
This works fine for me.

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.