736014 - "Copy rule" with some text selected copies that text additionally

Status: RESOLVED WORKSFORME

(DevTools :: Inspector, defect, P1)

Description

[Rimas Kudelis [use needinfo to ping]]

STR:
1. Open style inspector's Rules tab
2. Right-click on the name or value of any property. At least in Linux, the name/value will be selected and the context menu shown
3. Click on "Copy rule"
4. Paste the text elsewhere.

Here's an example of what I get when pasting:

body {
    font: 14px/1.428 "Lucida Grande","Lucida Sans Unicode",Lucida,Arial,Helvetica,sans-serif;
    14px/1.428 "Lucida Grande","Lucida Sans Unicode",Lucida,Arial,Helvetica,sans-serifcolor: rgb(51, 51, 51);
}

As you can see, the value was selected, because it gets pasted twice. This does happen with the latest nightly.

Comment 1

[Paul Rouget [:paul]]

I think it's in Aurora too.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch

I have tried to prevent the right mouse button from focusing the property editor but the context menu forces the element to focus in order to get the popupNode. Not showing the context menu would be confusing so allowing the editor to open, copy the rule and trim the cruft method is the best work around.

I don't think this is important enough to get into Aurora though.

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 606211 [details] [diff] [review]
Patch

I think it's quite important as it just breaks the "copy rule" feature. Let's get that in Aurora.

Comment 4

[Paul Rouget [:paul]]

Once this has landed, we should request for aurora approval.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/d7b1fd262d91

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/d7b1fd262d91

Comment 7

[Dave Camp (:dcamp)]

This is still broken.

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Interesting, I don't see how it was possible for this to happen. I have rewritten the "Copy Rule" code in bug 740603 so hopefully this is fixed.

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This works fine for me.