Last Comment Bug 740606 - Consider disabling the rule view's context menu
: Consider disabling the rule view's context menu
Product: Firefox
Classification: Client Software
Component: Developer Tools: Inspector (show other bugs)
: 13 Branch
: All All
-- normal (vote)
: ---
Assigned To: Dave Camp (:dcamp)
: Gabriel Luong [:gl][1 biz day review guarantee] (ΦωΦ)
Depends on: 740603 742196
  Show dependency treegraph
Reported: 2012-03-29 14:28 PDT by Dave Camp (:dcamp)
Modified: 2012-05-21 06:43 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Disable the context menu (9.56 KB, patch)
2012-04-09 11:50 PDT, Dave Camp (:dcamp)
rcampbell: review+
akeybl: approval‑mozilla‑aurora+
Details | Diff | Splinter Review

Description User image Dave Camp (:dcamp) 2012-03-29 14:28:39 PDT
The rule view's context menu has a couple pretty nasty bugs (bug 736014 and 740603).

If the fixes for those are small and low-risk, we should get them in aurora.  If not, we should unhook the context menu in aurora.
Comment 1 User image Dave Camp (:dcamp) 2012-04-09 11:50:39 PDT
Created attachment 613351 [details] [diff] [review]
Disable the context menu

The fix for the dependent bugs hasn't landed yet, I think we should disabled this menu in 13.
Comment 2 User image Rob Campbell [:rc] (:robcee) 2012-04-10 09:38:27 PDT
Comment on attachment 613351 [details] [diff] [review]
Disable the context menu

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

if you wanted to cut down on patch size, you could just comment out the offending test line in the makefile and not hg remove the actual test file.

Up to you.

Requesting Aurora Approval. This will quickly short-circuit our context menu in Aurora (13) which will prevent the occurrence of some nasty bugs. Risk is low.
Comment 3 User image Alex Keybl [:akeybl] 2012-04-10 12:20:45 PDT
Comment on attachment 613351 [details] [diff] [review]
Disable the context menu

[Triage Comment]
Approved for Aurora 13 - the patch looks fine as is.
Comment 5 User image Virgil Dicu [:virgil] [QA] 2012-05-21 06:43:27 PDT
Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20100101 Firefox/13.0

Context menu now disabled. verified in 13 beta4, Windows 7, Mac OS 10.6, Ubuntu 12.04

Note You need to log in before you can comment on or make changes to this bug.