Last Comment Bug 736049 - L10n repacks broken with Instant Messaging landing
: L10n repacks broken with Instant Messaging landing
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: All All
-- normal (vote)
: Thunderbird 14.0
Assigned To: Mark Banner (:standard8)
Depends on:
  Show dependency treegraph
Reported: 2012-03-15 05:31 PDT by Mark Banner (:standard8)
Modified: 2012-03-15 11:11 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

The fix (840 bytes, patch)
2012-03-15 05:31 PDT, Mark Banner (:standard8)
florian: review+
standard8: approval‑comm‑aurora+
Details | Diff | Splinter Review

Description User image Mark Banner (:standard8) 2012-03-15 05:31:08 PDT
Created attachment 606172 [details] [diff] [review]
The fix

When performing l10n repacks, we're seeing:

make[3]: Entering directory `/buildbot/comm-central-linux-l10n-full/build/comm-central/chat/components/public'
/buildbot/comm-central-linux-l10n-full/build/comm-central/mozilla/config/nsinstall -D ../../../mozilla/dist/idl
/buildbot/comm-central-linux-l10n-full/build/comm-central/mozilla/config/nsinstall -D ../../../mozilla/dist/idl
/tools/python/bin/python2.5 -u ../../../mozilla/config/ \
	  -I../../../mozilla/other-licenses/ply \
	  -I../../../mozilla/xpcom/idl-parser \
	  ../../../mozilla/xpcom/idl-parser/ --cachedir=../../../mozilla/xpcom/idl-parser -I. -I../../../mozilla/dist/idl imIAccount.idl -d .deps/imIAccount.h.pp -o _xpidlgen/imIAccount.h
Traceback (most recent call last):
  File "../../../mozilla/config/", line 52, in <module>
  File "../../../mozilla/config/", line 44, in main
    execfile(script, frozenglobals)
  File "../../../mozilla/xpcom/idl-parser/", line 531, in <module>
    idl.resolve(options.incdirs, p)
  File "/buildbot/comm-central-linux-l10n-full/build/comm-central/mozilla/xpcom/idl-parser/", line 318, in resolve
  File "/buildbot/comm-central-linux-l10n-full/build/comm-central/mozilla/xpcom/idl-parser/", line 288, in resolve
    raise IDLError("File '%s' not found" % self.filename, self.location)
xpidl.IDLError: error: File 'nsISupports.idl' not found, imIAccount.idl line 38:0
#include "nsISupports.idl"
make[3]: *** [_xpidlgen/imIAccount.h] Error 1

The issue is we're repacking in chat/ not chat/locales.
Comment 1 User image Florian Quèze [:florian] [:flo] (PTO until February 27) 2012-03-15 06:02:38 PDT
Comment on attachment 606172 [details] [diff] [review]
The fix

Oops, sorry about that, thanks for fixing it!
Comment 2 User image Mark Banner (:standard8) 2012-03-15 11:10:41 PDT
Comment on attachment 606172 [details] [diff] [review]
The fix

[Triage Comment]
We need this for aurora as well as chat is there.

Note You need to log in before you can comment on or make changes to this bug.