Closed
Bug 736049
Opened 13 years ago
Closed 13 years ago
L10n repacks broken with Instant Messaging landing
Categories
(Thunderbird :: Build Config, defect)
Thunderbird
Build Config
Tracking
(thunderbird13 fixed)
RESOLVED
FIXED
Thunderbird 14.0
Tracking | Status | |
---|---|---|
thunderbird13 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
840 bytes,
patch
|
florian
:
review+
standard8
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
When performing l10n repacks, we're seeing:
make[3]: Entering directory `/buildbot/comm-central-linux-l10n-full/build/comm-central/chat/components/public'
/buildbot/comm-central-linux-l10n-full/build/comm-central/mozilla/config/nsinstall -D ../../../mozilla/dist/idl
/buildbot/comm-central-linux-l10n-full/build/comm-central/mozilla/config/nsinstall -D ../../../mozilla/dist/idl
imIAccount.idl
/tools/python/bin/python2.5 -u ../../../mozilla/config/pythonpath.py \
-I../../../mozilla/other-licenses/ply \
-I../../../mozilla/xpcom/idl-parser \
../../../mozilla/xpcom/idl-parser/header.py --cachedir=../../../mozilla/xpcom/idl-parser -I. -I../../../mozilla/dist/idl imIAccount.idl -d .deps/imIAccount.h.pp -o _xpidlgen/imIAccount.h
Traceback (most recent call last):
File "../../../mozilla/config/pythonpath.py", line 52, in <module>
main(sys.argv[1:])
File "../../../mozilla/config/pythonpath.py", line 44, in main
execfile(script, frozenglobals)
File "../../../mozilla/xpcom/idl-parser/header.py", line 531, in <module>
idl.resolve(options.incdirs, p)
File "/buildbot/comm-central-linux-l10n-full/build/comm-central/mozilla/xpcom/idl-parser/xpidl.py", line 318, in resolve
p.resolve(self)
File "/buildbot/comm-central-linux-l10n-full/build/comm-central/mozilla/xpcom/idl-parser/xpidl.py", line 288, in resolve
raise IDLError("File '%s' not found" % self.filename, self.location)
xpidl.IDLError: error: File 'nsISupports.idl' not found, imIAccount.idl line 38:0
#include "nsISupports.idl"
^
make[3]: *** [_xpidlgen/imIAccount.h] Error 1
The issue is we're repacking in chat/ not chat/locales.
Attachment #606172 -
Flags: review?(florian)
Comment 1•13 years ago
|
||
Comment on attachment 606172 [details] [diff] [review]
The fix
Oops, sorry about that, thanks for fixing it!
Attachment #606172 -
Flags: review?(florian) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 606172 [details] [diff] [review]
The fix
[Triage Comment]
We need this for aurora as well as chat is there.
Attachment #606172 -
Flags: approval-comm-aurora+
Assignee | ||
Comment 3•13 years ago
|
||
Checked in:
http://hg.mozilla.org/comm-central/rev/7b9bb99a0dc9
http://hg.mozilla.org/releases/comm-aurora/rev/d318be5f503a
Status: NEW → RESOLVED
Closed: 13 years ago
status-thunderbird13:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
You need to log in
before you can comment on or make changes to this bug.
Description
•