Implement ANSystem::setPowerState for Flash

VERIFIED FIXED in Firefox 14

Status

()

Firefox for Android
General
P2
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: snorp, Assigned: snorp)

Tracking

Trunk
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox14 verified, firefox15 verified, firefox16 verified, blocking-fennec1.0 .N+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

This allows Flash to keep the screen on while playing videos, for instance.
Created attachment 606208 [details] [diff] [review]
Implement power state interface for Flash on Android
Attachment #606208 - Flags: review?(blassey.bugs)
Comment on attachment 606208 [details] [diff] [review]
Implement power state interface for Flash on Android

Review of attachment 606208 [details] [diff] [review]:
-----------------------------------------------------------------

have a look and dom/power and hal/android to see what can be shared
Attachment #606208 - Flags: review?(blassey.bugs)
Assignee: nobody → snorp
blocking-fennec1.0: --- → soft
Duplicate of this bug: 750522
Created attachment 626798 [details] [diff] [review]
Hook up Hal WakeLocks on Android and Flash
Attachment #626798 - Flags: review?(blassey.bugs)
Comment on attachment 626798 [details] [diff] [review]
Hook up Hal WakeLocks on Android and Flash

Review of attachment 626798 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/browser.js
@@ +244,5 @@
> +            state: state == "locked-foreground"
> +          }
> +        });
> +      }
> +    });

I don't like this indirection, just called sendMessageToJava directly from the plugin code. Or (if you don't want to construct JSON in C++) add a new method to the bridge
Attachment #626798 - Flags: review?(blassey.bugs) → review-
(In reply to Brad Lassey [:blassey] from comment #5)
> Comment on attachment 626798 [details] [diff] [review]
> Hook up Hal WakeLocks on Android and Flash
> 
> Review of attachment 626798 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/chrome/content/browser.js
> @@ +244,5 @@
> > +            state: state == "locked-foreground"
> > +          }
> > +        });
> > +      }
> > +    });
> 
> I don't like this indirection, just called sendMessageToJava directly from
> the plugin code. Or (if you don't want to construct JSON in C++) add a new
> method to the bridge

I did it that way the first time around, but in comment #2 you said you'd rather go through hal...
Depends on: 759799
Created attachment 628364 [details] [diff] [review]
Implement power state support for Flash on Android
Attachment #628364 - Flags: review?(blassey.bugs)
Attachment #626798 - Attachment is obsolete: true
Attachment #628364 - Flags: review?(blassey.bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8243c3234fe

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/d8243c3234fe
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
Comment on attachment 628364 [details] [diff] [review]
Implement power state support for Flash on Android

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:
Attachment #628364 - Flags: approval-mozilla-beta?
Attachment #628364 - Flags: approval-mozilla-aurora?
tracking-fennec: --- → 14+
blocking-fennec1.0: soft → .N+
Comment on attachment 628364 [details] [diff] [review]
Implement power state support for Flash on Android

we're going to take this for the .N release, so please land on aurora and beta but not the beta 7 release branch on beta
Attachment #628364 - Flags: approval-mozilla-beta?
Attachment #628364 - Flags: approval-mozilla-beta+
Attachment #628364 - Flags: approval-mozilla-aurora?
Attachment #628364 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-beta/rev/6b309ab6a0b2
tracking-fennec: 14+ → ---
https://hg.mozilla.org/releases/mozilla-aurora/rev/4f4776ead212
status-firefox14: --- → fixed
status-firefox15: --- → fixed
status-firefox16: --- → fixed
Setting screen timeout to a short interval and leaving youtube flash video player in fullscreen mode causes the timeout to be disabled and leaves the device awake until the video completes. 

Tested on:
Nightly 16.0a1 2012-06-19/ Aurora 15.0a2 2012-06-19/ Firefox Mobile 14 beta 7
HTC Desire
Android 2.2
Status: RESOLVED → VERIFIED
status-firefox14: fixed → verified
status-firefox15: fixed → verified
status-firefox16: fixed → verified
You need to log in before you can comment on or make changes to this bug.