736073 - Implement ANSystem::setPowerState for Flash

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

This allows Flash to keep the screen on while playing videos, for instance.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Implement power state interface for Flash on Android

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 606208 [details] [diff] [review]
Implement power state interface for Flash on Android

Review of attachment 606208 [details] [diff] [review]:
-----------------------------------------------------------------

have a look and dom/power and hal/android to see what can be shared

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Hook up Hal WakeLocks on Android and Flash

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 626798 [details] [diff] [review]
Hook up Hal WakeLocks on Android and Flash

Review of attachment 626798 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/browser.js
@@ +244,5 @@
> +            state: state == "locked-foreground"
> +          }
> +        });
> +      }
> +    });

I don't like this indirection, just called sendMessageToJava directly from the plugin code. Or (if you don't want to construct JSON in C++) add a new method to the bridge

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Brad Lassey [:blassey] from comment #5)
> Comment on attachment 626798 [details] [diff] [review]
> Hook up Hal WakeLocks on Android and Flash
> 
> Review of attachment 626798 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/chrome/content/browser.js
> @@ +244,5 @@
> > +            state: state == "locked-foreground"
> > +          }
> > +        });
> > +      }
> > +    });
> 
> I don't like this indirection, just called sendMessageToJava directly from
> the plugin code. Or (if you don't want to construct JSON in C++) add a new
> method to the bridge

I did it that way the first time around, but in comment #2 you said you'd rather go through hal...

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Implement power state support for Flash on Android

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8243c3234fe

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d8243c3234fe

Comment 10

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 628364 [details] [diff] [review]
Implement power state support for Flash on Android

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 628364 [details] [diff] [review]
Implement power state support for Flash on Android

we're going to take this for the .N release, so please land on aurora and beta but not the beta 7 release branch on beta

Comment 12

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-beta/rev/6b309ab6a0b2

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4f4776ead212

Comment 14

[Adrian Tamas (:AdrianT)]

Setting screen timeout to a short interval and leaving youtube flash video player in fullscreen mode causes the timeout to be disabled and leaves the device awake until the video completes. 

Tested on:
Nightly 16.0a1 2012-06-19/ Aurora 15.0a2 2012-06-19/ Firefox Mobile 14 beta 7
HTC Desire
Android 2.2