736085 - Link slavename to the recent list of jobs for that slave

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Armen [:armenzg]]

This is actually very useful and I can't believe no one has thought of it before.

When we click on a tbpl job we have the slavename printed in there:
> s: mv-moz2-linux-ix-slave05
If we turned that into a hyperlink it will make easier to catch machines that have gone rogue:
https://build.mozilla.org/buildapi/recent/mv-moz2-linux-ix-slave05

I bet this can make the life of philor and others much better.

I can provide patch if you point me to the source code.

Thanks!

Comment 1

[Markus Stange [:mstange]]

Code is here: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/tip/js/UserInterface.js#l1561
and probably needs to be somewhere here: http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/file/tip/js/MachineResult.js

Good luck! :)

Comment 2

[Steve Fink [:sfink] [:s:]]

I didn't know that page existed. I like the idea. But that page isn't all that useful right now; the only column of interest is 'Result'. It needs the revision and a link to the log, or at least the build number needs to be a link to somewhere useful. (Though I don't know what that build number is; it seems to be a strangely low number, so it's not the uid that I'd expect.)

Comment 3

[Ed Morley [:emorley]]

Attachment: Patch v1

Applies on top of the patches in bug 812472.

The current slavename is in the TinderboxPrint section, but I think making the scrape linkify it is just adding to the mess that is already there. In the buildbot world, we already have access to the slave name outside of the log, so lets use that instead, and once this has landed in TBPL-production, we can turn off the multiple slave name tinderboxprint buildsteps.

As such this patch:
* Removes the pretty redundant "using revision: mozilla-central/58ebb638a7ea" row to free up some space (I can't really see why anyone would use this row).
* Adds a row of form "using slave: tegra-278" where the slavename links to https://build.mozilla.org/buildapi/recent/tegra-278 etc.
* Cleans up an unrelated redundancy in the htmlForBuilds() function.

Comment 4

[Ed Morley [:emorley]]

Attachment: Screenshot

Comment 5

[Arpad Borsos [:Swatinem]]

Comment on attachment 682448 [details] [diff] [review]
Patch v1

Review of attachment 682448 [details] [diff] [review]:
-----------------------------------------------------------------

Back in the days, this was intended for jobs that pulled from more than one repo...

Comment 6

[Ed Morley [:emorley]]

Thank you for the review :-)

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/9bda68ffeda9

Comment 7

[Ed Morley [:emorley]]

In production.