812472 - Clean up Config.js BaseURLs

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

As part of bug 736085, I'll be linking to the buildAPI.

Whilst we have the URL for it specified in Config.js, it is currently named "htmlPendingOrRunningBaseURL", which is going to get confusing.

We should clean up some of the naming & also consistently include the trailing slash.

Comment 1

[Ed Morley [:emorley]]

Attachment: Part 1: s/htmlPendingOrRunningBaseURL/buildapiURL/

Comment 2

[Ed Morley [:emorley]]

(I'm not a great fan of the redundant "BaseURL" vs "URL", so getting rid of it where appropriate)

Comment 3

[Ed Morley [:emorley]]

Attachment: Part 2: s/selfServeAPIBaseURL/selfServeURL/, fix trailing slash, base on buildapiURL

Comment 4

[Ed Morley [:emorley]]

Attachment: Part 3: s/jsonPendingOrRunningBaseURL/buildjsonURL/

Comment 5

[Ed Morley [:emorley]]

Attachment: Part 4: s/treeStatusBaseURL/treeStatusURL/

Comment 6

[Ed Morley [:emorley]]

I'm not going to ask review specifically, given the trivial nature of these patches, but won't land until bug 736085 is finished and had review, in case there are any objections here.

Comment 7

[Ed Morley [:emorley]]

Attachment: Part 2: s/selfServeAPIBaseURL/selfServeURL/, fix trailing slash

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/ce27a3865512
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/5940dec9d9d7
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/adf3fd99580c
https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/82c2a4739fb2

Comment 9

[Ed Morley [:emorley]]

In production.