736386 - A commit missing a bug number slipped past the commit message hook

Status: RESOLVED DUPLICATE of bug 698221

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Jesse Ruderman]

How did this get past the commit message hook added in bug 506949 / bug 692932?

http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=790be8926d50

It was backed out in http://hg.mozilla.org/mozilla-central/rev/e2c7eb54fded, but the hook should have caught it and prevented the need for a backout.

Comment 1

[Ben Kero [:bkero]]

This repository definitely has the commitmessage hook enabled on it.  I'm not sure why it failed as I did not write this hook.  If you would like help debugging this problem I will be happy to help, although I don't have commit access to this repository.

The bug for hook creation is 506949

The author of the hook is Tom Schuster (evilpies), who is already CC'ed to this bug.

[root@dm-svn02 .hg]# pwd  
/repo/hg/mozilla/integration/mozilla-inbound/.hg
[root@dm-svn02 .hg]# cat hgrc
[paths]
default = /repo/hg/mozilla/mozilla-central

[hooks]
pretxnchangegroup.a_treeclosure = python:mozhghooks.treeclosure.hook
pretxnchangegroup.b_singlehead = python:mozhghooks.single_head_per_branch.hook
pretxnchangegroup.c_commitmessage = python:mozhghooks.commit-message.hook

Comment 2

[Tom S. (please needinfo tschuster)]

So I think I know how this happened. Notice the date of the commit 'Aug 22 11:14:13 2011', and we still allow stuff before October 2011-

I am just going to attach a patch for this in bug 698221. I need somebody to land that.