Intermittent TEST-UNEXPECTED-FAIL | browser_tabview_bug600645.js | The app tab icon has the right tab reference

RESOLVED FIXED in Firefox 14

Status

defect
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

({intermittent-failure})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

https://tbpl.mozilla.org/php/getParsedLog.php?id=10111908&tree=Fx-Team

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug600645.js | The app tab icon has the right tab reference - Got [object XULElement @ 0xce72ee0 (native @ 0xd675fb0)], expected [object XULElement @ 0xc4a9fb8 (native @ 0xc351dc8)]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug600645.js | The icon url starts with moz-anno:favicon so the default fav icon would be displayed
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Posted patch patch v1Splinter Review
Haven't had a single occurrence in 15 m-oth runs on try. This fix seems necessary even without the intermittent orange now that I (think I) found the issue.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #607155 - Flags: review?(dietrich)
Comment on attachment 607155 [details] [diff] [review]
patch v1

Review of attachment 607155 [details] [diff] [review]:
-----------------------------------------------------------------

seems fine, r=me. an improvement might be an ensureXULTab method that does all that, and can be re-used in other places where we get favicons, thumbnails or even other async scenarios where this same xul tab check needs to occur.
Attachment #607155 - Flags: review?(dietrich) → review+
(In reply to Dietrich Ayala (:dietrich) from comment #20)
> seems fine, r=me. an improvement might be an ensureXULTab method that does
> all that, and can be re-used in other places where we get favicons,
> thumbnails or even other async scenarios where this same xul tab check needs
> to occur.

Ok, I'll file a follow-up for this.
https://hg.mozilla.org/integration/fx-team/rev/90d3b1fb284d
Whiteboard: [orange] → [orange][fixed-in-fx-team]
Target Milestone: --- → Firefox 14
Yeah, I won't be that guy :) Filed follow-up bug 737032.
Target Milestone: Firefox 14 → ---
(Assignee)

Updated

7 years ago
Target Milestone: --- → Firefox 14
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
https://hg.mozilla.org/mozilla-central/rev/90d3b1fb284d
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Comment hidden (Legacy TBPL/Treeherder Robot)
Comment hidden (Legacy TBPL/Treeherder Robot)
Whiteboard: [orange]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.