Closed
Bug 736424
Opened 12 years ago
Closed 12 years ago
Intermittent TEST-UNEXPECTED-FAIL | browser_tabview_bug600645.js | The app tab icon has the right tab reference
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 14
People
(Reporter: ttaubert, Assigned: ttaubert)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
1.09 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
https://tbpl.mozilla.org/php/getParsedLog.php?id=10111908&tree=Fx-Team TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug600645.js | The app tab icon has the right tab reference - Got [object XULElement @ 0xce72ee0 (native @ 0xd675fb0)], expected [object XULElement @ 0xc4a9fb8 (native @ 0xc351dc8)] TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug600645.js | The icon url starts with moz-anno:favicon so the default fav icon would be displayed
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 19•12 years ago
|
||
Haven't had a single occurrence in 15 m-oth runs on try. This fix seems necessary even without the intermittent orange now that I (think I) found the issue.
Comment 20•12 years ago
|
||
Comment on attachment 607155 [details] [diff] [review] patch v1 Review of attachment 607155 [details] [diff] [review]: ----------------------------------------------------------------- seems fine, r=me. an improvement might be an ensureXULTab method that does all that, and can be re-used in other places where we get favicons, thumbnails or even other async scenarios where this same xul tab check needs to occur.
Attachment #607155 -
Flags: review?(dietrich) → review+
Assignee | ||
Comment 21•12 years ago
|
||
(In reply to Dietrich Ayala (:dietrich) from comment #20) > seems fine, r=me. an improvement might be an ensureXULTab method that does > all that, and can be re-used in other places where we get favicons, > thumbnails or even other async scenarios where this same xul tab check needs > to occur. Ok, I'll file a follow-up for this.
Assignee | ||
Comment 22•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/90d3b1fb284d
Whiteboard: [orange] → [orange][fixed-in-fx-team]
Target Milestone: --- → Firefox 14
Comment 23•12 years ago
|
||
ok, just don't be this guy. http://mozillamemes.tumblr.com/post/19391417219
Assignee | ||
Comment 24•12 years ago
|
||
Yeah, I won't be that guy :) Filed follow-up bug 737032.
Target Milestone: Firefox 14 → ---
Assignee | ||
Updated•12 years ago
|
Target Milestone: --- → Firefox 14
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Assignee | ||
Comment 27•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/90d3b1fb284d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Comment hidden (Legacy TBPL/Treeherder Robot) |
Comment hidden (Legacy TBPL/Treeherder Robot) |
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•