Intermittent TEST-UNEXPECTED-FAIL | browser_tabview_bug600645.js | The app tab icon has the right tab reference

RESOLVED FIXED in Firefox 14

Status

Firefox Graveyard
Panorama
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: ttaubert, Assigned: ttaubert)

Tracking

({intermittent-failure})

Trunk
Firefox 14
intermittent-failure

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=10111908&tree=Fx-Team

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug600645.js | The app tab icon has the right tab reference - Got [object XULElement @ 0xce72ee0 (native @ 0xd675fb0)], expected [object XULElement @ 0xc4a9fb8 (native @ 0xc351dc8)]
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/tabview/test/browser_tabview_bug600645.js | The icon url starts with moz-anno:favicon so the default fav icon would be displayed
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 19

5 years ago
Created attachment 607155 [details] [diff] [review]
patch v1

Haven't had a single occurrence in 15 m-oth runs on try. This fix seems necessary even without the intermittent orange now that I (think I) found the issue.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #607155 - Flags: review?(dietrich)
Comment on attachment 607155 [details] [diff] [review]
patch v1

Review of attachment 607155 [details] [diff] [review]:
-----------------------------------------------------------------

seems fine, r=me. an improvement might be an ensureXULTab method that does all that, and can be re-used in other places where we get favicons, thumbnails or even other async scenarios where this same xul tab check needs to occur.
Attachment #607155 - Flags: review?(dietrich) → review+
(Assignee)

Comment 21

5 years ago
(In reply to Dietrich Ayala (:dietrich) from comment #20)
> seems fine, r=me. an improvement might be an ensureXULTab method that does
> all that, and can be re-used in other places where we get favicons,
> thumbnails or even other async scenarios where this same xul tab check needs
> to occur.

Ok, I'll file a follow-up for this.
(Assignee)

Comment 22

5 years ago
https://hg.mozilla.org/integration/fx-team/rev/90d3b1fb284d
Whiteboard: [orange] → [orange][fixed-in-fx-team]
Target Milestone: --- → Firefox 14
ok, just don't be this guy. http://mozillamemes.tumblr.com/post/19391417219
(Assignee)

Comment 24

5 years ago
Yeah, I won't be that guy :) Filed follow-up bug 737032.
Target Milestone: Firefox 14 → ---
(Assignee)

Updated

5 years ago
Target Milestone: --- → Firefox 14
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 27

5 years ago
https://hg.mozilla.org/mozilla-central/rev/90d3b1fb284d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-fx-team] → [orange]
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Keywords: intermittent-failure
Whiteboard: [orange]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.