736488 - Test and fix middleware code for ElasticSearch

Status: VERIFIED FIXED

(Socorro Graveyard :: Middleware, defect, P1)

Description

[[DEACTIVATED] Adrian Gaudebert]

The code for ElasticSearch in the middleware is getting old and hasn't been testing in a while. It needs tests and bug fixes for search and report/list code.

Comment 1

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/f0094cbabeee39815a0ab46178dd10394c3f071b
Fixes bug 736488 - Fixed bugs in middleware code for ElasticSearch.

https://github.com/mozilla/socorro/commit/ce3bfd37eb4b4b30c848c3b4dad35d1d001c431e
Merge pull request #454 from AdrianGaudebert/736488-test-fix-middleware-elasticsearch

Fixes bug 736488 - Fixed bugs in middleware code for ElasticSearch.

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Testing search with ElasticSearch
---------------------------------

1. Go to advanced search
2. Run a search with one of those parameters:
    * product = Firefox
    * product = Thunderbird
    * versions = All
    * versions = one single version
    * versions = two or three different versions
    * OS = none (which means, all)
    * OS = Linux
    * OS = Windows and Mac
    * Period = 1 week before now
    * Period = 1 day before now
    * Period = 1 hour before any date in the previous week
    * Signature = contains js
    * Signature = starts_with ns
    * Signature = exactly nsGenericElement::UnbindFromTree(bool, bool)  (implies product = Firefox)
    * Crash reason = SIGSEGV
    * Build id = 20120319031122
    * Build id = 20120319031122+20120317031150
    * Report process = Browser
    * Report process = Plugin
    * Report process = Content (product = Fennec)
    * Report type = Crash
    * Report type = Hang
3. For each search, add to the URL '&force_api_impl=elasticsearch' to run that same query with ElasticSearch
4. Compare results of the two search (PostgreSQL and ElasticSearch) and verify they are identical

Comment 3

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/f0d0c2e41c1e2c77b4cd308427d37776872d1033
Fixes bug 736488 - Fixed bugs in middleware code for ElasticSearch.

Comment 4

[[DEACTIVATED] Adrian Gaudebert]

Moving to 4 because we cannot QA this yet.

Comment 5

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/f0d0c2e41c1e2c77b4cd308427d37776872d1033
Fixes bug 736488 - Fixed bugs in middleware code for ElasticSearch.

Comment 6

[[github robot]]

Commit pushed to v3-branch at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/f0d0c2e41c1e2c77b4cd308427d37776872d1033
Fixes bug 736488 - Fixed bugs in middleware code for ElasticSearch.

Comment 7

[Matt Brandt [:mbrandt]]

When using posgres results are returned for:
https://crash-stats.allizom.org/query/query?product=Firefox&version=Firefox%3A15.0a2&platform=mac&range_value=1&range_unit=weeks&date=07%2F17%2F2012+20%3A41%3A47&query_search=signature&query_type=contains&query=&reason=&build_id=&process_type=any&hang_type=any&do_query=1

For the same search using ES no results are returned:
https://crash-stats.allizom.org/query/query?product=Firefox&version=Firefox%3A15.0a2&platform=mac&range_value=1&range_unit=weeks&date=07%2F17%2F2012+20%3A41%3A47&query_search=signature&query_type=contains&query=&reason=&build_id=&process_type=any&hang_type=any&do_query=1&force_api_impl=elasticsearch

Comment 8

[[DEACTIVATED] Adrian Gaudebert]

Moving to future until we have a viable test environment.

Comment 9

[[DEACTIVATED] Adrian Gaudebert]

QA can now begin! On stage, it won't work with Firefox because we lack some of the data in HBase and thus elasticsearch, but it should work just fine for all other products. For example, FennecAndroid has quite a bit of data and could be a good product to use for testing. 

Note that what you add at the end of the search url is now ``&_force_api_impl=elasticsearch`` (there is an underscore at the beginning of the parameter). 

One good way to verify that data comes from elasticsearch is to have a search that returns more than 1,000 results with postgres, and run it with elasticsearch: if it shows exactly 1,000 results, then that's elasticsearch, if it shows more then it can only come from postgres (and if it shows less than 1,000 there is no obvious way of saying but looking into the logs).

Comment 10

[Matt Brandt [:mbrandt]]

Nudging to resolved since this feature is ready for [qa+]

Comment 11

[Matt Brandt [:mbrandt]]

Reopening:

Per a conversation with Adrian in irc it seems the OS filter doesn't work with Linux.

Non-elastic search - returns 9,877 results
https://crash-stats.allizom.org/query/query?product=FennecAndroid&version=ALL%3AALL&platform=windows&platform=mac&platform=linux&range_value=1&range_unit=weeks&date=07%2F17%2F2012+20%3A41%3A47&query_search=signature&query_type=contains&query=&reason=&build_id=&process_type=any&hang_type=any&do_query=1

Elastic search - returns 0 results
https://crash-stats.allizom.org/query/query?product=FennecAndroid&version=ALL%3AALL&platform=windows&platform=mac&platform=linux&range_value=1&range_unit=weeks&date=07%2F17%2F2012+20%3A41%3A47&query_search=signature&query_type=contains&query=&reason=&build_id=&process_type=any&hang_type=any&do_query=1&_force_api_impl=elasticsearch

Comment 12

[[DEACTIVATED] Adrian Gaudebert]

The bug above is non-existent, it was a problem with dates. However, while investigating I found a different bug with socorro-crashstats sending OS short names instead of full values, and fixed it: https://github.com/mozilla/socorro/pull/1247

Comment 13

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/411da20c2f2190f709bd8dfe8998b80494c1ecef
Fixes bug 736488 - Accept short os names in search with elasticsearch.

https://github.com/mozilla/socorro/commit/2a1267264510286d10633cea77e758c09c5817de
Merge pull request #1247 from AdrianGaudebert/736488-os-short

Fixes bug 736488 - Accept short os names in search with elasticsearch.

Comment 14

[Matt Brandt [:mbrandt]]

QA verified on stage -- automation is passing as well as exploratory testing surrounding the steps-to-test in comment 2