Closed Bug 736542 Opened 8 years ago Closed 8 years ago

Bug 727637 causes about:newaddon to not show up with magically appearing XPI's

Categories

(Firefox :: General, defect)

13 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 + verified

People

(Reporter: WeirdAl, Assigned: Unfocused)

References

()

Details

(Keywords: regression, testcase, Whiteboard: [qa+])

Attachments

(1 file)

Steps to reproduce:
(1) Download the XPI given in the URL field (do NOT install, just download)
(2) Launch FF13 Aurora build to establish profile
(3) Close FF13 Aurora entirely.
(4) Copy the XPI file into the profile's extensions folder.
(5) Launch FF13 again with the same profile.

Expected result:
about:newaddon?id=test-update@alexvincent.us appears in a new tab.

Actual result:
No about:newaddon page appears.
Backing out the patch from bug 727637 does restore the expected behavior.
Tracking for FF13. Given https://bugzilla.mozilla.org/show_bug.cgi?id=727637#c3, it sounds like we should just do the backout.
Attached patch Patch v1Splinter Review
This undoes bug 727637. Once this lands, I'll re-open bug 727637.
Attachment #607516 - Flags: review?(dtownsend+bugmail)
Any idea why that patch broke this?
Comment on attachment 607516 [details] [diff] [review]
Patch v1

Review of attachment 607516 [details] [diff] [review]:
-----------------------------------------------------------------

Confused why this is breaking but yes let's back it out on aurora
Attachment #607516 - Flags: review?(dtownsend+bugmail) → review+
(In reply to Gavin Sharp (use gavin@gavinsharp.com for email) from comment #4)
> Any idea why that patch broke this?

Oh, yes - it moved code using |this| into a callback function, so |this| isn't what it expects it to be. Easy fix, but I figured backout was still the safe option for Aurora.
Status: NEW → ASSIGNED
https://hg.mozilla.org/integration/fx-team/rev/d23d714bc491
Flags: in-testsuite-
Flags: in-litmus-
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 14
Comment on attachment 607516 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Regression caused by (bug #): bug 727637
User impact if declined: User won't get prompted to enable forgeign-installed addon
Testing completed (on m-c, etc.): Manual
Risk to taking this patch (and alternatives if risky): Minimal risk - back out of bug 727637, which was an optimization, not a behaviour change.
String changes made by this patch: None.
Attachment #607516 - Flags: approval-mozilla-aurora?
Attachment #607516 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/d23d714bc491
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Blair can you do the uplift to aurora on this in the next day or so?
Whiteboard: [qa+]
Verified on Firefox 13 beta 3 using the steps to reproduce from the description that the about:newaddon page is opened after launching the browser.

Verified as fixed on Windows 7, Ubuntu 12.04 and Mac OS X 10.6:
Mozilla/5.0 (Windows NT 6.1; rv:13.0) Gecko/20100101 Firefox/13.0
Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20100101 Firefox/13.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20100101 Firefox/13.0
You need to log in before you can comment on or make changes to this bug.