Forwarded mail is incorrectly presented in the plaintext editor.

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Mail Window Front End
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Mike Hoye, Assigned: mconley)

Tracking

({regression})

Trunk
Thunderbird 14.0
x86
All
regression

Thunderbird Tracking Flags

(thunderbird13+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:14.0) Gecko/20120316 Firefox/14.0a1
Build ID: 20120316031151

Steps to reproduce:

 
I have this message in my sentmail folder: 


-------------


Hello, folks -

I'm just following up about the tech demo I showed you in late January. Have you come to any conclusions about it?

Thanks,

-- 
Michael Hoye
Bespoke I/O
http://bespokeio.com 

-------------





and when I click "Forward", I see this:

-------------

-------- Original Message --------

Subject: Re: WebFWD Intro

Date: Tue, 14 Feb 2012 11:34:55 -0500

From: Mike Hoye <mhoye@bespokeio.com>

To: Pascal Finette | Mozilla <pfinette@mozilla.com>

CC: Diane Bisgeier <dbisgeier@mozilla.com>


Hello, folks -




Thanks,
















I'm just following up about the tech demo I showed you in late January. Have you come to any conclusions about it?

-- Michael HoyeBespoke I/Ohttp://bespokeio.com

-------------

Because wat.


Actual results:


http://pastebin.mozilla.org/1522640 




Expected results:


Not that.
Blocks: 698925
Assignee: nobody → mconley
Keywords: regression
OS: Mac OS X → All
tracking-thunderbird13: --- → ?
Summary: Forwarded mail is incorrectly presented in the editor. → Forwarded mail is incorrectly presented in the plaintext editor.
Created attachment 606708 [details] [diff] [review]
Patch v1

First run at a patch.
Comment on attachment 606708 [details] [diff] [review]
Patch v1

It's funny - the bug I was seeing before, where carriage returns were being truncated...I'm not seeing it now.  I wonder if the changes made to nsMsgCompose.cpp fixed that.  :/

Regardless, this *seems* to fix things.  Do you have cycles to test / review this, Jim?
Attachment #606708 - Flags: review?(squibblyflabbetydoo)
A workaround for now is to forward mail using the HTML editor (press and hold Shift while clicking Forward to do this).

Comment 4

5 years ago
Confirmed with today's trunk nightly. Forwarding as attachment is broken as well, I'll file a separate bug on that.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 5

5 years ago
(confirmed that it's broken badly, I mean, not that the patch works - the message is basically completely rearranged when forwarding inline...)

Comment 6

5 years ago
Comment on attachment 606708 [details] [diff] [review]
Patch v1

Review of attachment 606708 [details] [diff] [review]:
-----------------------------------------------------------------

This works for me, too.
Attachment #606708 - Flags: review?(squibblyflabbetydoo) → review+
Attachment #606708 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/c212bdbccf39
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
rsx11m:

When tonight's Daily gets spun out, mind taking it for a spin to see if we've fully resolved the issue?

Thanks!

-Mike

Updated

5 years ago
Attachment #606708 - Flags: approval-comm-aurora? → approval-comm-aurora+
Pushed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/5924288478d6
status-thunderbird13: --- → fixed

Comment 10

5 years ago
Looking at Thunderbird/14.0a1 BuildID=20120319030043 on Windows 7, the main issue seems to be fixed with today's nightly. The spacing in the forwarded part matches the original spacing. However, there is an additional blank line now at the very top of the plain-text composition window (i.e., three blank lines before the "---Original Message---" heading instead of two as before). This may be unrelated to the bug here though, given that a simple "Write" opens the composition window with an additional blank line on top in the editor which wasn't there before.
tracking-thunderbird13: ? → ---
tracking-thunderbird13: --- → +
You need to log in before you can comment on or make changes to this bug.