The default bug view has changed. See this FAQ.

On some linux systems webrtc fails to link due to not finding XML_* functions from expat

RESOLVED FIXED

Status

()

Core
WebRTC
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jesup, Unassigned)

Tracking

Trunk
All
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

5 years ago
This is references from libjingle, which uses 'normal' expat (char, not PR_UniChar).
Fails on builders and on Ethan's Ubuntu 11.10, not on Fedora 15x64

Probably a side-effect of the SipCC checkin or maybe Bas's

libjingle tries to use system expat on linux, but instead ends up looking for an internal link symbol.  May be an include-path issue at the heart.
(Reporter)

Comment 1

5 years ago
Created attachment 606739 [details] [diff] [review]
hack to paper over the external expat problem by building it internal
(Reporter)

Updated

5 years ago
Blocks: 688178
(Reporter)

Comment 2

5 years ago
Comment on attachment 606739 [details] [diff] [review]
hack to paper over the external expat problem by building it internal

Note: this patch is not for eventual checkin to mozilla-central; the include issue that causes the base problem should be solved, and this bug kept open until then
Attachment #606739 - Flags: feedback?(ethanhugg)

Comment 3

5 years ago
Comment on attachment 606739 [details] [diff] [review]
hack to paper over the external expat problem by building it internal

Review of attachment 606739 [details] [diff] [review]:
-----------------------------------------------------------------

This fixes the problem where it breaks on Ubuntu64 but succeeds on Fedora15.  Building expat internally reduces risk of build platform variability.  The only downside I see is a marginally longer build time.
(Reporter)

Comment 4

5 years ago
hack checked in as https://hg.mozilla.org/projects/alder/rev/10a5f0e2bc71
(Reporter)

Updated

5 years ago
Attachment #606739 - Flags: feedback?(ethanhugg) → feedback+
(Reporter)

Comment 5

5 years ago
Created attachment 606831 [details] [diff] [review]
Temp hack - Use system expat on Mac but not linux
(Reporter)

Comment 6

5 years ago
Attachment 606831 [details] [diff] - Partial backout of previous patch - re-enable system expat on Mac

https://hg.mozilla.org/projects/alder/rev/41d5c11a453f
(Reporter)

Comment 7

5 years ago
Created attachment 606841 [details] [diff] [review]
Temp hack (fixed) - Use system expat on Mac but not linux
(Reporter)

Updated

5 years ago
Attachment #606831 - Attachment is obsolete: true

Comment 8

5 years ago
Created attachment 616262 [details] [diff] [review]
Fix for this linkage problem

We really don't want to use the system lib on Mac, but we get collisions with the existing expat. The following patch munges the unmunged symbols on the existing expat so that doesn't happen and then uses the libjingle/third_party expat.
(Reporter)

Comment 9

5 years ago
Comment on attachment 616262 [details] [diff] [review]
Fix for this linkage problem

f+ with mods to fold expat back into the main list of libs (and remove the now-spurious comment)
Attachment #616262 - Flags: feedback+
Checked in with nits as: http://hg.mozilla.org/projects/alder/rev/70cddbbd129b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.