736633 - extract only the needed keys from request.GET

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Ryan Kelly [:rfkelly]]

Attachment: patch to explicitly extract GET params

This patch replaces the use of controller.view(**request.GET) with code to explicitly extract only those keys we're interested in.  This resolves an issue with newer WebOb releases where request.GET has unicode keys.

Comment 1

[Toby Elliott [:telliott]]

Comment on attachment 606772 [details] [diff] [review]
patch to explicitly extract GET params

r+ as a viable solution to the core problem, but I don't think it's the correct solution going forward, as we'll find ourselves rewriting the hack over and over. 

We should either use a dict here, have a helper function in mozsvc that strips unicode keys from a given list, or do something magic in cornice.

Comment 2

[Ryan Kelly [:rfkelly]]

Committed in https://github.com/mozilla-services/server-syncstorage/commit/73e7e0e51bb6f15d2d3c2bcc2f5119a370e880de

I think we only hit this due to legacy code being ported over to pyramid, and the correct solution is "don't pass request.GET directly as **kwargs".

Comment 3

[James Bonacci [:jbonacci]]

Code verified and passed functional tests of Sync 2.0 and AITC 1.0 for a current deploy to qa1.