Closed Bug 736735 Opened 12 years ago Closed 12 years ago

notification.css: Use inheritance instead of non-performant css.

Categories

(Toolkit :: XUL Widgets, defect)

Product:
Toolkit
Component:
XUL Widgets
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: philip.chee, Assigned: philip.chee)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch v1.0 use inheritance.
4.31 KB, patch
Dolske
: review+
Details | Diff | Splinter Review 
There are several bugs that could be more easily fixed if we were a bit more clever in our XBL e.g.
Bug 415400 - notification bar icons aren't accessible through CSS
Bug 694786 - Remove hard coded dependency on xpinstallItemGeneric.png from notification.xml.
This would be super useful in SeaMonkey because then we can remove hard coded image chrome paths and do things like:

.messageImage[type][value="plugin-crashed"] {
  list-style-image: url("chrome://mozapps/skin/plugins/notifyPluginCrashed.png");
}

.messageImage[type][value="addon-install-complete"] {
  list-style-image: url("chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png");
}
Attachment #606871 - Flags: review?(dolske)
Attachment #606871 - Flags: feedback?(ehume)
Blocks: 694786
No longer depends on: 694786
Attachment #606871 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/20031e64e0f3
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
Attachment #606871 - Flags: feedback?(ehume)
Thanks for thinking of me. I can't really comment on the javascript, but the css looks much better. It looks skinnable.
You need to log in before you can comment on or make changes to this bug.