notification.css: Use inheritance instead of non-performant css.

RESOLVED FIXED in mozilla14

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: philip.chee, Assigned: philip.chee)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
There are several bugs that could be more easily fixed if we were a bit more clever in our XBL e.g.
Bug 415400 - notification bar icons aren't accessible through CSS
Bug 694786 - Remove hard coded dependency on xpinstallItemGeneric.png from notification.xml.
(Assignee)

Comment 1

7 years ago
Created attachment 606871 [details] [diff] [review]
Patch v1.0 use inheritance.

This would be super useful in SeaMonkey because then we can remove hard coded image chrome paths and do things like:

.messageImage[type][value="plugin-crashed"] {
  list-style-image: url("chrome://mozapps/skin/plugins/notifyPluginCrashed.png");
}

.messageImage[type][value="addon-install-complete"] {
  list-style-image: url("chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png");
}
Attachment #606871 - Flags: review?(dolske)
Attachment #606871 - Flags: feedback?(ehume)
(Assignee)

Updated

7 years ago
Blocks: 694786
No longer depends on: 694786
Attachment #606871 - Flags: review?(dolske) → review+
https://hg.mozilla.org/mozilla-central/rev/20031e64e0f3
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
(Assignee)

Updated

7 years ago
Attachment #606871 - Flags: feedback?(ehume)

Comment 4

7 years ago
Thanks for thinking of me. I can't really comment on the javascript, but the css looks much better. It looks skinnable.
You need to log in before you can comment on or make changes to this bug.