Closed
Bug 694786
Opened 13 years ago
Closed 12 years ago
Remove hardcoded icon paths from notification.xml.
Categories
(SeaMonkey :: Themes, defect)
SeaMonkey
Themes
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: InvisibleSmiley, Assigned: philip.chee)
References
Details
Attachments
(1 file, 2 obsolete files)
34.20 KB,
patch
|
stefanh
:
review+
|
Details | Diff | Splinter Review |
From bug 693844 comment 1: There is one reference to chrome://mozapps/skin/xpinstall/xpinstallItemGeneric.png in suite/common/bindings/notification.xml KaiRo already noticed this in https://bugzilla.mozilla.org/show_bug.cgi?id=572043#c22 > Don't care about modern, and I actually hate how notification.xml directly > points to an URL without giving themes to point to a possibly > differently-named file. I think we should avoid hard coding image paths in themes (or anywhere else). Looking at the toolkit PopupNotifications.jsm for inspiration: In our notification.xml::addonInstallBlocked(), we can add at the end: var notification = this.appendNotification(messageString, notificationName, iconURL, priority, buttons); notification.setAttribute("class", notificationName); Then in navigator.css near /* ::::: notification popups ::::: */ we can add: .addon-install-blocked { list-style-image: url("chrome://mozapps/skin/extensions/extensionGeneric.png"); } or perhaps: .addon-install-blocked > .notification-inner > hbox > .messageImage { list-style-image: url("chrome://mozapps/skin/extensions/extensionGeneric.png"); } May need !important; to override the default icons in global/notifications.css.
Assignee | ||
Updated•12 years ago
|
Assignee | ||
Updated•12 years ago
|
Summary: Remove hard coded dependency on xpinstallItemGeneric.png from notification.xml → Remove hard icon paths from notification.xml.
Assignee | ||
Comment 1•12 years ago
|
||
Includes fix for Bug 511874: Notification bar should use 16x16 versions of icons. > +.messageImage[type][value="plugin-crashed"] { > + list-style-image: url("chrome://mozapps/skin/plugins/pluginGeneric-16.png"); [...] > +.messageImage[type][value="indexedDB-permissions-prompt"], > +.messageImage[type][value="indexedDB-quota-prompt"] { > + list-style-image: url("chrome://global/skin/icons/question-16.png"); Fixes Bug 511874: Notification bar should use 16x16 versions of icons. > .popup-notification-icon[popupid="indexedDB-permissions-prompt"], > .popup-notification-icon[popupid="indexedDB-quota-prompt"] { > - list-style-image: url("chrome://global/skin/icons/question64.png"); > + list-style-image: url("chrome://global/skin/icons/question-64.png"); Somewhere along the way toolkit renamed question64.png to question-64.png. > +++ b/suite/themes/modern/global/notification.css [....] > -.notification-inner[type="info"] > hbox > .messageImage { > +.messageImage[type="info"] { > list-style-image: url("chrome://global/skin/icons/information-16.png"); > } > > -.notification-inner[type="warning"] > hbox > .messageImage { > +.messageImage[type="warning"] { > list-style-image: url("chrome://global/skin/icons/warning-16.png"); > } > > -.notification-inner[type="critical"] > hbox > .messageImage { > +.messageImage[type="critical"] { > list-style-image: url("chrome://global/skin/icons/error-16.png"); > } This ports my toolkit fix for Bug 736735 (notification.css: Use inheritance instead of non-performant css). > +++ b/suite/themes/modern/jar.mn [....] > skin/modern/global/icons/pg-portrait-small.gif (global/icons/pg-portrait-small.gif) > + skin/modern/global/icons/Question.png (global/icons/Question.png) In Bug 539066 I added Question.png but forgot to add it to jar.mn!! > skin/modern/global/icons/question-16.png (global/icons/question-16.png) > + skin/modern/global/icons/question-64.png (global/icons/question-64.png) Add question-64.png > +++ b/suite/themes/modern/navigator/navigator.css [....] > .popup-notification-icon[popupid="indexedDB-permissions-prompt"], > .popup-notification-icon[popupid="indexedDB-quota-prompt"] { > - list-style-image: url("chrome://global/skin/icons/alert-question.gif"); > - width: 46px; > - height: 36px; > + list-style-image: url("chrome://global/skin/icons/question-64.png"); > } And get rid of the width/height hack.
Assignee | ||
Updated•12 years ago
|
Summary: Remove hard icon paths from notification.xml. → Remove hardcoded icon paths from notification.xml.
Comment 2•12 years ago
|
||
(In reply to Philip Chee from comment #1) > > .popup-notification-icon[popupid="indexedDB-permissions-prompt"], > > .popup-notification-icon[popupid="indexedDB-quota-prompt"] { > > - list-style-image: url("chrome://global/skin/icons/question64.png"); > > + list-style-image: url("chrome://global/skin/icons/question-64.png"); > Somewhere along the way toolkit renamed question64.png to question-64.png. Eek! Do we need to fix this on any branches?
Assignee | ||
Comment 3•12 years ago
|
||
>> Somewhere along the way toolkit renamed question64.png to question-64.png. Looking at Hg blame it seems to have always been question-64.png since it landed via Bug 429282 - "Land new windows icons (20080416)" > Eek! Do we need to fix this on any branches? I'd say probably maybe. Nobody seems to have noticed it missing in the MailNews MDN notification bar.
Assignee | ||
Comment 4•12 years ago
|
||
> - list-style-image: url("chrome://global/skin/icons/question64.png"); Blame says question64.png introduced by Neil via Bug 595810 Part 8c: implement indexedDB doorhanger
Comment 5•12 years ago
|
||
Oops. Any chance of a separate bug so we can get it backported? Thanks :-)
Assignee | ||
Comment 6•12 years ago
|
||
> Oops. Any chance of a separate bug so we can get it backported? Thanks :-)
Please file a bug and assign to me thanks! I probably won't be ablee to get around to this until after the weekend though.
Comment 7•12 years ago
|
||
Comment on attachment 619098 [details] [diff] [review] Patch v1.0 Fixit. >diff --git a/suite/themes/classic/mac/navigator/navigator.css b/suite/themes/classic/mac/navigator/navigator.css The best way of associating the styles with notifications would be a scoped stylesheet. Unfortunately the notification element is separate from the notificationbox so we would have to create a new derived binding for notification elements. Failing that, the styles belong in communicator.css rather than navigator.css (which is doorhangers only). >+.messageImage[type][value="refresh-blocked"] { .messageImage[value="foo"] should cascade after .messageImage[type="foo"] >+.messageImage[type][value="indexedDB-permissions-prompt"], >+.messageImage[type][value="indexedDB-quota-prompt"] { >+ list-style-image: url("chrome://global/skin/icons/question-16.png"); Why this change? > .popup-notification-icon[popupid="indexedDB-permissions-prompt"], > .popup-notification-icon[popupid="indexedDB-quota-prompt"] { >- list-style-image: url("chrome://global/skin/icons/alert-question.gif"); >- width: 46px; >- height: 36px; >+ list-style-image: url("chrome://global/skin/icons/question-64.png"); Why this change?
Attachment #619098 -
Flags: review?(neil) → review-
Assignee | ||
Comment 8•12 years ago
|
||
>>diff --git a/suite/themes/classic/mac/navigator/navigator.css b/suite/themes/classic/mac/navigator/navigator.css > The best way of associating the styles with notifications would be a scoped > stylesheet. Unfortunately the notification element is separate from the > notificationbox so we would have to create a new derived binding for > notification elements. Failing that, the styles belong in communicator.css > rather than navigator.css (which is doorhangers only). Fixed. >>+.messageImage[type][value="refresh-blocked"] { > .messageImage[value="foo"] should cascade after .messageImage[type="foo"] Fixed. >>+.messageImage[type][value="indexedDB-permissions-prompt"], >>+.messageImage[type][value="indexedDB-quota-prompt"] { >>+ list-style-image: url("chrome://global/skin/icons/question-16.png"); > Why this change? The doorhanger uses a question icon. I thought we should be consistent when using a notificationbox. >> .popup-notification-icon[popupid="indexedDB-permissions-prompt"], >> .popup-notification-icon[popupid="indexedDB-quota-prompt"] { >>- list-style-image: url("chrome://global/skin/icons/alert-question.gif"); >>- width: 46px; >>- height: 36px; >>+ list-style-image: url("chrome://global/skin/icons/question-64.png"); > Why this change? alert-question.gif is 46x36px so needs a hack to prevent it from being stretched. Also it doesn't have a transparent background. I've replaced it with question-64.png from Kuden's Past Modern which is 64x64 and has an alpha transparent background.
Attachment #619098 -
Attachment is obsolete: true
Attachment #622045 -
Flags: review?(neil)
Assignee | ||
Comment 9•12 years ago
|
||
Comment on attachment 622045 [details] [diff] [review] Patch v1.1 fix issues. ping stefanh for Mac review. To test run the following in navigator chrome context: gBrowser.getNotificationBox().appendNotification("refresh-blocked", "refresh-blocked", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("blocked-plugins", "blocked-plugins", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("missing-plugins", "missing-plugins", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("outdated-plugins", "outdated-plugins", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("carbon-failure-plugins", "carbon-failure-plugins", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("plugin-crashed", "plugin-crashed", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("click-to-play-plugins", "click-to-play-plugins", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("addon-install-blocked", "addon-install-blocked", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("addon-install-cancelled", "addon-install-cancelled", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("addon-install-complete", "addon-install-complete", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("addon-install-disabled", "addon-install-disabled", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("addon-install-failed", "addon-install-failed", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("addon-install-started", "addon-install-started", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("lwtheme-install-request", "lwtheme-install-request", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("lwtheme-install-notification", "lwtheme-install-notification", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("popup-blocked", "popup-blocked", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("indexedDB-permissions-prompt", "indexedDB-permissions-prompt", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []); gBrowser.getNotificationBox().appendNotification("indexedDB-quota-prompt", "indexedDB-quota-prompt", null,gBrowser.getNotificationBox().PRIORITY_INFO_MEDIUM, []);
Attachment #622045 -
Flags: review?(stefanh)
Comment 10•12 years ago
|
||
Comment on attachment 622045 [details] [diff] [review] Patch v1.1 fix issues. >- <xul:image anonid="messageImage" class="messageImage" xbl:inherits="src=image"/> >+ <xul:image anonid="messageImage" class="messageImage" xbl:inherits="src=image,type,value"/> Good catch, but we actually have three notification overrides. r=me with that and your line endings fixed.
Attachment #622045 -
Flags: review?(neil) → review+
Assignee | ||
Comment 11•12 years ago
|
||
>>- <xul:image anonid="messageImage" class="messageImage" xbl:inherits="src=image"/>
>>+ <xul:image anonid="messageImage" class="messageImage" xbl:inherits="src=image,type,value"/>
> Good catch, but we actually have three notification overrides.
> r=me with that and your line endings fixed.
Fixed.
Over to Stefan for Mac review.
Attachment #622045 -
Attachment is obsolete: true
Attachment #622045 -
Flags: review?(stefanh)
Attachment #622649 -
Flags: review?(stefanh)
Updated•12 years ago
|
Attachment #622649 -
Flags: review?(stefanh) → review+
Assignee | ||
Comment 12•12 years ago
|
||
Pushed to comm-central: http://hg.mozilla.org/comm-central/rev/2e313a301e28 Includes fix for Bug 511874 Notification bar should use 16x16 versions of icons. Also fixes DOS line endings in classic/mac/messenger/primaryToolbar.css.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•