Last Comment Bug 736763 - CanSkipInCC when adding roots
: CanSkipInCC when adding roots
Status: RESOLVED FIXED
[snappy]
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Andrew McCreight [:mccr8]
:
Mentors:
Depends on:
Blocks: 716598 722715
  Show dependency treegraph
 
Reported: 2012-03-17 11:34 PDT by Andrew McCreight [:mccr8]
Modified: 2012-03-22 13:45 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
simple patch (1.00 KB, patch)
2012-03-17 11:36 PDT, Andrew McCreight [:mccr8]
bugs: review+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2012-03-17 11:34:57 PDT
When building the graph, we first add a bunch of XPConnect roots.  These are checked using CanSkipThis.  Then we add things from the purple buffer, which are checked using CanSkipInCC.  Any children of these nodes are checked via CanSkipThis.  We're already calling CanSkipInCC during graph construction, so hopefully it is safe.

If we check XPConnect roots using CanSkipInCC instead of CanSkipThis, we should be able to remove some more nodes from the graph.  This clarifies the role of these two functions a bit: CanSkipInCC is more like CanSkipRoot, and CanSkipThis is more like CanSkipChild.
Comment 1 Andrew McCreight [:mccr8] 2012-03-17 11:36:29 PDT
Created attachment 606889 [details] [diff] [review]
simple patch

This passed the try run along with my various other patches I put up for review today. https://tbpl.mozilla.org/?tree=Try&rev=869ed959b506
Comment 2 Andrew McCreight [:mccr8] 2012-03-18 07:20:46 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f19f2215180
Comment 3 Phil Ringnalda (:philor) 2012-03-18 13:14:51 PDT
https://hg.mozilla.org/mozilla-central/rev/7f19f2215180

Note You need to log in before you can comment on or make changes to this bug.