Closed Bug 736763 Opened 8 years ago Closed 8 years ago

CanSkipInCC when adding roots

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [snappy])

Attachments

(1 file)

When building the graph, we first add a bunch of XPConnect roots.  These are checked using CanSkipThis.  Then we add things from the purple buffer, which are checked using CanSkipInCC.  Any children of these nodes are checked via CanSkipThis.  We're already calling CanSkipInCC during graph construction, so hopefully it is safe.

If we check XPConnect roots using CanSkipInCC instead of CanSkipThis, we should be able to remove some more nodes from the graph.  This clarifies the role of these two functions a bit: CanSkipInCC is more like CanSkipRoot, and CanSkipThis is more like CanSkipChild.
Attached patch simple patchSplinter Review
This passed the try run along with my various other patches I put up for review today. https://tbpl.mozilla.org/?tree=Try&rev=869ed959b506
Assignee: nobody → continuation
Attachment #606889 - Flags: review?(bugs)
Blocks: 716598
Attachment #606889 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/7f19f2215180
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 722715
Whiteboard: [snappy]
You need to log in before you can comment on or make changes to this bug.