CanSkipInCC when adding roots

RESOLVED FIXED in mozilla14

Status

()

Core
XPCOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [snappy])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
When building the graph, we first add a bunch of XPConnect roots.  These are checked using CanSkipThis.  Then we add things from the purple buffer, which are checked using CanSkipInCC.  Any children of these nodes are checked via CanSkipThis.  We're already calling CanSkipInCC during graph construction, so hopefully it is safe.

If we check XPConnect roots using CanSkipInCC instead of CanSkipThis, we should be able to remove some more nodes from the graph.  This clarifies the role of these two functions a bit: CanSkipInCC is more like CanSkipRoot, and CanSkipThis is more like CanSkipChild.
(Assignee)

Comment 1

5 years ago
Created attachment 606889 [details] [diff] [review]
simple patch

This passed the try run along with my various other patches I put up for review today. https://tbpl.mozilla.org/?tree=Try&rev=869ed959b506
Assignee: nobody → continuation
Attachment #606889 - Flags: review?(bugs)
(Assignee)

Updated

5 years ago
Blocks: 716598

Updated

5 years ago
Attachment #606889 - Flags: review?(bugs) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f19f2215180
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/7f19f2215180
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Blocks: 722715
Whiteboard: [snappy]
You need to log in before you can comment on or make changes to this bug.