Closed
Bug 736864
Opened 13 years ago
Closed 13 years ago
Port |Bug 736770 - --disable-updater packaging errors| to SeaMonkey
Categories
(SeaMonkey :: Build Config, defect, P2)
SeaMonkey
Build Config
Tracking
(seamonkey2.8 wontfix, seamonkey2.9 fixed, seamonkey2.10 fixed)
RESOLVED
FIXED
seamonkey2.11
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Flags: in-testsuite-
|
Assignee | |
Comment 1•13 years ago
|
||
removed-files.in:
*updater.app/Contents/MacOS/updater.ini: already listed earlier.
*update.locale: simpler to always remove it.
Attachment #606991 -
Flags: review?(bugspam.Callek)
Attachment #606991 -
Flags: approval-comm-beta?
Attachment #606991 -
Flags: approval-comm-aurora?
|
|
Assignee | |
Updated•13 years ago
|
status-seamonkey2.10:
--- → affected
status-seamonkey2.8:
--- → wontfix
status-seamonkey2.9:
--- → affected
|
|
Assignee | |
Updated•13 years ago
|
|
|
Assignee | |
Updated•13 years ago
|
Attachment #606991 -
Flags: approval-comm-beta?
Attachment #606991 -
Flags: approval-comm-aurora?
|
||
Comment 2•13 years ago
|
||
Comment on attachment 606991 [details] [diff] [review]
(Av1) packaging: Add 'MOZ_UPDATER' condition for 3 files, Sort '[@AB_CD@]' files, Sync' removed-files.in
Review of attachment 606991 [details] [diff] [review]:
-----------------------------------------------------------------
Marking r+ but iirc the MOZ_UPDATER define itself is going away, I think that bug is assigned to you too, so if it is I'd be less inclined to fix this issue with this patch and instead just port the removal of --disable-updater to c-c.
Attachment #606991 -
Flags: review?(bugspam.Callek) → review+
|
|
||
Comment 3•13 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #2)
> Comment on attachment 606991 [details] [diff] [review]
> (Av1) packaging: Add 'MOZ_UPDATER' condition for 3 files, Sort '[@AB_CD@]'
> files, Sync' removed-files.in
>
> Review of attachment 606991 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Marking r+ but iirc the MOZ_UPDATER define itself is going away,
Nope I was thinking of MOZ_INSTALLER. Carry on
|
|
Assignee | |
Comment 4•13 years ago
|
||
Av1, but playing it safer wrt update.locale.
I have a doubt (wrt installer / full update / partial update), so I changed my mind :-|
Attachment #606991 -
Attachment is obsolete: true
Attachment #609122 -
Flags: review?(bugspam.Callek)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #609122 -
Attachment filename: 736864-Av1_MOZ_UPDATER.diff → 736864-Av2_MOZ_UPDATER.diff
|
|
Assignee | |
Comment 5•13 years ago
|
||
Ping for review.
|
|
||
Updated•13 years ago
|
Attachment #609122 -
Flags: review?(bugspam.Callek) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Comment on attachment 609122 [details] [diff] [review]
(Av2) packaging: Add 'MOZ_UPDATER' condition for 3 files, Sort '[@AB_CD@]' files, Sync' removed-files.in
[Checked in: Comment 6 & 8 & 7]
http://hg.mozilla.org/comm-central/rev/b72e3df108b7
[Approval Request Comment]
Risk to taking this patch (and alternatives if risky):
No risk, NPOdefaultB packaging only.
Attachment #609122 -
Attachment description: (Av2) packaging: Add 'MOZ_UPDATER' condition for 3 files, Sort '[@AB_CD@]' files, Sync' removed-files.in → (Av2) packaging: Add 'MOZ_UPDATER' condition for 3 files, Sort '[@AB_CD@]' files, Sync' removed-files.in
[Checked in: Comment 6]
Attachment #609122 -
Flags: approval-comm-beta?
Attachment #609122 -
Flags: approval-comm-aurora?
|
|
Assignee | |
Updated•13 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
||
Updated•13 years ago
|
Attachment #609122 -
Flags: approval-comm-beta?
Attachment #609122 -
Flags: approval-comm-beta+
Attachment #609122 -
Flags: approval-comm-aurora?
Attachment #609122 -
Flags: approval-comm-aurora+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
Whiteboard: [c-n: b72e3df108b7 to c-a and c-b]
|
|
||
Comment 7•13 years ago
|
||
[beta] needed to adjust for context changes in removed-files and package-manifest
[beta] http://hg.mozilla.org/releases/comm-beta/rev/9b0476ac8947
Whiteboard: [c-n: b72e3df108b7 to c-a and c-b] → [c-n: b72e3df108b7 to c-a]
|
|
||
Comment 8•13 years ago
|
||
Keywords: checkin-needed
Whiteboard: [c-n: b72e3df108b7 to c-a]
|
|
Assignee | |
Updated•13 years ago
|
Attachment #609122 -
Attachment description: (Av2) packaging: Add 'MOZ_UPDATER' condition for 3 files, Sort '[@AB_CD@]' files, Sync' removed-files.in
[Checked in: Comment 6] → (Av2) packaging: Add 'MOZ_UPDATER' condition for 3 files, Sort '[@AB_CD@]' files, Sync' removed-files.in
[Checked in: Comment 6 & 8 & 7]
You need to log in
before you can comment on or make changes to this bug.
Description
•