Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Contacts API: Add pictures

RESOLVED FIXED in mozilla17

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gwagner, Assigned: gwagner)

Tracking

(Blocks: 1 bug)

unspecified
mozilla17
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

16.14 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
We want to store pictures in the contacts DB.
(Assignee)

Updated

5 years ago
Blocks: 746443
(Assignee)

Updated

5 years ago
Summary: Contacts API: Add pictures → Contacts API: Add pictures, messagetone, ringtone
(Assignee)

Comment 1

5 years ago
I guess ringtone and messagetone are similar to pictures.
We want ringones and message tones per-contact and not per number right?
How do we want to store them in the DB?
Assignee: nobody → anygregor
(Assignee)

Comment 2

5 years ago
The current solution is to put strings into the DB and use the mediastorage API to retrieve the pictures. That should already work.
In order to put pictures in the DB, the framemessagemanager has to be able to transfer blobs.
(Assignee)

Updated

5 years ago
Depends on: 754353

Updated

5 years ago
blocking-basecamp: --- → +
Gregor has confirmed that comment #2 is what we're doing for now and that should be sufficient for Basecamp.
blocking-basecamp: + → ---
(Assignee)

Updated

5 years ago
Summary: Contacts API: Add pictures, messagetone, ringtone → Contacts API: Add pictures
(Assignee)

Comment 4

5 years ago
Created attachment 648916 [details] [diff] [review]
patch
Attachment #648916 - Flags: review?(bent.mozilla)
Comment on attachment 648916 [details] [diff] [review]
patch

Review of attachment 648916 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/ContactManager.js
@@ +173,5 @@
> +        for (let i = 0; i < aBlob.length; i++) {
> +          if (typeof aBlob != 'object') {
> +            return null;
> +          }
> +          if (aBlob[i] instanceof Components.interfaces.nsIDOMBlob) {

Nit: if (!(aBlob[] instanceof ...))

@@ +183,5 @@
> +        return aBlob;
> +      }
> +      return null;
> +    };
> +    

Nit: whitespace
Attachment #648916 - Flags: review?(bent.mozilla) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a5ad716bb8e

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/3a5ad716bb8e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.