Closed Bug 736883 Opened 9 years ago Closed 9 years ago

Contacts API: Add pictures

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla17

People

(Reporter: gwagner, Assigned: gwagner)

References

Details

Attachments

(1 file)

We want to store pictures in the contacts DB.
Blocks: b2g-contact
Summary: Contacts API: Add pictures → Contacts API: Add pictures, messagetone, ringtone
I guess ringtone and messagetone are similar to pictures.
We want ringones and message tones per-contact and not per number right?
How do we want to store them in the DB?
Assignee: nobody → anygregor
The current solution is to put strings into the DB and use the mediastorage API to retrieve the pictures. That should already work.
In order to put pictures in the DB, the framemessagemanager has to be able to transfer blobs.
Depends on: 754353
blocking-basecamp: --- → +
Gregor has confirmed that comment #2 is what we're doing for now and that should be sufficient for Basecamp.
blocking-basecamp: + → ---
Summary: Contacts API: Add pictures, messagetone, ringtone → Contacts API: Add pictures
Attached patch patchSplinter Review
Attachment #648916 - Flags: review?(bent.mozilla)
Comment on attachment 648916 [details] [diff] [review]
patch

Review of attachment 648916 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/ContactManager.js
@@ +173,5 @@
> +        for (let i = 0; i < aBlob.length; i++) {
> +          if (typeof aBlob != 'object') {
> +            return null;
> +          }
> +          if (aBlob[i] instanceof Components.interfaces.nsIDOMBlob) {

Nit: if (!(aBlob[] instanceof ...))

@@ +183,5 @@
> +        return aBlob;
> +      }
> +      return null;
> +    };
> +    

Nit: whitespace
Attachment #648916 - Flags: review?(bent.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/3a5ad716bb8e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.