736883 - Contacts API: Add pictures

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gregor Wagner [:gwagner]]

We want to store pictures in the contacts DB.

Comment 1

[Gregor Wagner [:gwagner]]

I guess ringtone and messagetone are similar to pictures.
We want ringones and message tones per-contact and not per number right?
How do we want to store them in the DB?

Comment 2

[Gregor Wagner [:gwagner]]

The current solution is to put strings into the DB and use the mediastorage API to retrieve the pictures. That should already work.
In order to put pictures in the DB, the framemessagemanager has to be able to transfer blobs.

Comment 3

[Andrew Overholt [:overholt]]

Gregor has confirmed that comment #2 is what we're doing for now and that should be sufficient for Basecamp.

Comment 4

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 648916 [details] [diff] [review]
patch

Review of attachment 648916 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/ContactManager.js
@@ +173,5 @@
> +        for (let i = 0; i < aBlob.length; i++) {
> +          if (typeof aBlob != 'object') {
> +            return null;
> +          }
> +          if (aBlob[i] instanceof Components.interfaces.nsIDOMBlob) {

Nit: if (!(aBlob[] instanceof ...))

@@ +183,5 @@
> +        return aBlob;
> +      }
> +      return null;
> +    };
> +    

Nit: whitespace

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a5ad716bb8e

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3a5ad716bb8e