736934 - Handle version specific redirects by Bedrock to make .htaccess maintenance-free

Status: VERIFIED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Alex Keybl [:akeybl]]

We need to figure out a way to set a single aurora, beta, release, and esr version in a single place for .htaccess. Right now we're running into bugs like bug 736698 every release.

Comment 1

[Alex Keybl [:akeybl]]

James - any ideas here?

Comment 2

[Kohei Yoshino [:kohei]]

mozilla.jp has a PHP redirector code using version data (like firefoxDetails.class.php) so our .hteaccess is maintenance-free.

Comment 3

[Kohei Yoshino [:kohei]]

... So I'll write a patch tomorrow. Bug 705416 will also lighten akeybl's workload.

Comment 4

[Kohei Yoshino [:kohei]]

Attachment: Use PHP-based redirector for version-dependent URLs, instead of maintaining .htaccess

Comment 5

[Kohei Yoshino [:kohei]]

Attachment: patch v2 (do not cache redirects)

Comment 6

[James Long (:jlongster)]

This is a good goal, but we need to figure out if we should go ahead and do this on the Python said. We're in the middle of switching over everything to Python and I'd hate to add one more edge case to the PHP code that we have to port over in a few weeks. Let me figure out if we can fit this in soon.

Comment 7

[Alex Keybl [:akeybl]]

(In reply to James Long (:jlongster) from comment #6)
> This is a good goal, but we need to figure out if we should go ahead and do
> this on the Python said. We're in the middle of switching over everything to
> Python and I'd hate to add one more edge case to the PHP code that we have
> to port over in a few weeks. Let me figure out if we can fit this in soon.

Can we move forward with this? As seen in bug 738203, we're still running into htaccess problems given the complexity of the rules (if that is in fact the problem).

Comment 8

[Kohei Yoshino [:kohei]]

I have no experience in Git and Python so it would be appreciated if someone could port my PHP patch (attachment 607523 [details] [diff] [review]) to Bedrock.

Comment 9

[Kohei Yoshino [:kohei]]

Comment on attachment 607523 [details] [diff] [review]
patch v2 (do not cache redirects)

I'll write a redirector code for Bedrock, based on my previous patch for the legacy PHP side.

Comment 10

[Kohei Yoshino [:kohei]]

Attachment: .htaccess diff in the PHP side

Pull request for Bedrock: https://github.com/mozilla/bedrock/pull/1004

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/b8c81c37674ca8d142c58a2ae55fc16764fccf12
Bug 736934 - Figure out way to set single aurora, beta, release, esr versions in single place for .htaccess

Making `.htaccess` maintenance free.

https://github.com/mozilla/bedrock/commit/cf88a028cf902068f4b564e44472a1fcc4daa96a
Merge pull request #1004 from kyoshino/bug-736934-redirector

Bug 736934 - Figure out way to set single aurora, beta, release, esr versions in single place for .htaccess

Comment 12

[Paul [:pmac] McLanahan]

We do still need to cleanup the .htaccess file, but I'm sure :kohei's patch is out of date since Fx 23 is out. Once this hits prod we can update the patch. We'll also need to contact Release Management to let them know that they can drop the .htaccess update step from their release tasks.

Comment 13

[Kohei Yoshino [:kohei]]

Attachment: .htaccess diff in the PHP side

Updated my patch for the .htaccess file in the PHP side.

Yes, it's good news for the RelEng team! .htaccess and firefox/releases/index.html (Bug 705416) are now maintenance-free!

Comment 14

[Kohei Yoshino [:kohei]]

I should have changed the bug summary earlier...

Comment 15

[Kohei Yoshino [:kohei]]

My Bedrock PR has been pushed to prod by pmac.

(In reply to Kohei Yoshino [:kohei] from comment #13)
> Created attachment 792569 [details] [diff] [review]
> .htaccess diff in the PHP side

Committed this patch to trunk in r119183.
Those redirects should work well as before:

https://www-dev.allizom.org/en-US/firefox/notes/
https://www-dev.allizom.org/en-US/firefox/beta/notes/
https://www-dev.allizom.org/en-US/firefox/aurora/notes/
https://www-dev.allizom.org/en-US/mobile/notes/
https://www-dev.allizom.org/en-US/mobile/beta/notes/
https://www-dev.allizom.org/en-US/mobile/aurora/notes/

https://www-dev.allizom.org/en-US/firefox/system-requirements.html

https://www-dev.allizom.org/en-US/firefox/24.0/releasenotes/
should show the same page as
https://www-dev.allizom.org/en-US/firefox/24.0beta/releasenotes/

Comment 16

[Kohei Yoshino [:kohei]]

But... the following redirect is not working correctly. My bad :(

https://www-dev.allizom.org/en-US/firefox/beta/notes/
actual:   https://www-dev.allizom.org/en-US/mobile/24.0b1/releasenotes/
expected: https://www-dev.allizom.org/en-US/mobile/24.0beta/releasenotes/

https://www-dev.allizom.org/en-US/mobile/beta/notes/ is also.

Will fix it up soon.

Comment 17

[Kohei Yoshino [:kohei]]

Fixed the issue and ADDED TESTS:
https://github.com/mozilla/bedrock/pull/1182

Comment 18

[Kohei Yoshino [:kohei]]

My pull request 1182 has been merged. So now all links in Comment 15 work as expected. r119183 should be merged to stage/prod once the PR hits prod.

Comment 19

[raymond [:retornam] (inactive)]

https://www.allizom.org/en-US/firefox/23.0.1/releasenotes/
https://www.allizom.org/en-US/firefox/24.0beta/releasenotes/

Comment 20

[raymond [:retornam] (inactive)]

fxied on stage https://www-dev.allizom.org/en-US/mobile/25.0a2/auroranotes/

Comment 21

[raymond [:retornam] (inactive)]

fixed on production
https://www.mozilla.org/en-US/firefox/23.0.1/releasenotes/
https://www.mozilla.org/en-US/firefox/24.0beta/releasenotes/

Comment 22

[Kohei Yoshino [:kohei]]

pmac: could you merge r119183 to stage/prod?

Comment 23

[Paul [:pmac] McLanahan]

Merged to prod in r121584.