Map role=note to IA2 role NOTE instead of SECTION

RESOLVED FIXED in mozilla14

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: davidb, Assigned: capella)

Tracking

(Blocks: 1 bug)

unspecified
mozilla14
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=eitan@monotonous.org][lang=c++][ARIA conformance])

Attachments

(1 attachment)

Reported by conformance testers. (Be mindful of bug 610362)
Whiteboard: [ARIA conformance]

Comment 1

6 years ago
spec: http://www.w3.org/WAI/PF/aria/roles#note
impl guide: http://www.w3.org/WAI/PF/aria-implementation/#mapping_role_table

put an entry for role note to nsARIAMap.cpp (similar to "math" entry).
Whiteboard: [ARIA conformance] → [good first bug][mentor=eitan@monotonous.org][lang=c++][ARIA conformance]

Comment 2

6 years ago
add a test to test_aria_roles.html
(Assignee)

Updated

6 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 3

6 years ago
Created attachment 608294 [details] [diff] [review]
Patch (v1)

test_aria_roles.html fails before code changes are applied to nsariamap.cpp (found 107 expected 123), pass just fine afterwards.

Let me know if you need anything further here -- mark
Attachment #608294 - Flags: review?(eitan)
Comment on attachment 608294 [details] [diff] [review]
Patch (v1)

Review of attachment 608294 [details] [diff] [review]:
-----------------------------------------------------------------

(r=me)
Attachment #608294 - Flags: review+
Comment on attachment 608294 [details] [diff] [review]
Patch (v1)

Review of attachment 608294 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #608294 - Flags: review?(eitan) → review+
(Assignee)

Updated

6 years ago
Blocks: 734982

Updated

6 years ago
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86 → All

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/98b90ef66f24
https://hg.mozilla.org/mozilla-central/rev/98b90ef66f24
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.