Closed Bug 737156 Opened 10 years ago Closed 10 years ago

Map role=note to IA2 role NOTE instead of SECTION

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: davidb, Assigned: capella)

References

(Blocks 1 open bug)

Details

(Whiteboard: [good first bug][mentor=eitan@monotonous.org][lang=c++][ARIA conformance])

Attachments

(1 file)

Reported by conformance testers. (Be mindful of bug 610362)
Whiteboard: [ARIA conformance]
spec: http://www.w3.org/WAI/PF/aria/roles#note
impl guide: http://www.w3.org/WAI/PF/aria-implementation/#mapping_role_table

put an entry for role note to nsARIAMap.cpp (similar to "math" entry).
Whiteboard: [ARIA conformance] → [good first bug][mentor=eitan@monotonous.org][lang=c++][ARIA conformance]
add a test to test_aria_roles.html
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Attached patch Patch (v1)Splinter Review
test_aria_roles.html fails before code changes are applied to nsariamap.cpp (found 107 expected 123), pass just fine afterwards.

Let me know if you need anything further here -- mark
Attachment #608294 - Flags: review?(eitan)
Comment on attachment 608294 [details] [diff] [review]
Patch (v1)

Review of attachment 608294 [details] [diff] [review]:
-----------------------------------------------------------------

(r=me)
Attachment #608294 - Flags: review+
Comment on attachment 608294 [details] [diff] [review]
Patch (v1)

Review of attachment 608294 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #608294 - Flags: review?(eitan) → review+
Blocks: 734982
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86 → All
https://hg.mozilla.org/mozilla-central/rev/98b90ef66f24
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.