Closed
Bug 737156
Opened 12 years ago
Closed 12 years ago
Map role=note to IA2 role NOTE instead of SECTION
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: davidb, Assigned: capella)
References
(Blocks 1 open bug)
Details
(Whiteboard: [good first bug][mentor=eitan@monotonous.org][lang=c++][ARIA conformance])
Attachments
(1 file)
2.46 KB,
patch
|
eeejay
:
review+
davidb
:
review+
|
Details | Diff | Splinter Review |
Reported by conformance testers. (Be mindful of bug 610362)
Reporter | ||
Updated•12 years ago
|
Whiteboard: [ARIA conformance]
Comment 1•12 years ago
|
||
spec: http://www.w3.org/WAI/PF/aria/roles#note impl guide: http://www.w3.org/WAI/PF/aria-implementation/#mapping_role_table put an entry for role note to nsARIAMap.cpp (similar to "math" entry).
Whiteboard: [ARIA conformance] → [good first bug][mentor=eitan@monotonous.org][lang=c++][ARIA conformance]
Comment 2•12 years ago
|
||
add a test to test_aria_roles.html
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•12 years ago
|
||
test_aria_roles.html fails before code changes are applied to nsariamap.cpp (found 107 expected 123), pass just fine afterwards. Let me know if you need anything further here -- mark
Attachment #608294 -
Flags: review?(eitan)
Reporter | ||
Comment 4•12 years ago
|
||
Comment on attachment 608294 [details] [diff] [review] Patch (v1) Review of attachment 608294 [details] [diff] [review]: ----------------------------------------------------------------- (r=me)
Attachment #608294 -
Flags: review+
Comment 5•12 years ago
|
||
Comment on attachment 608294 [details] [diff] [review] Patch (v1) Review of attachment 608294 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks!
Attachment #608294 -
Flags: review?(eitan) → review+
Updated•12 years ago
|
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86 → All
Comment 7•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/98b90ef66f24
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•