Closed Bug 737301 Opened 9 years ago Closed 9 years ago

make package fails with safe browsing disabled

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla14

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file)

Due to missing ifdefs, disabling safe browsing now causes build failures due to |make package| failing on errors.
Attached patch patchSplinter Review
Attachment #607407 - Flags: review?(khuey)
Comment on attachment 607407 [details] [diff] [review]
patch

You should update removed-files.in too.
Attachment #607407 - Flags: feedback-
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> Comment on attachment 607407 [details] [diff] [review]
> patch
> 
> You should update removed-files.in too.

Why? This doesn't affect official builds where the files would be present and the files won't be there to be removed in self-made builds.
https://hg.mozilla.org/integration/mozilla-inbound/rev/47e510cf2416
Flags: in-testsuite-
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/47e510cf2416
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 14 → mozilla14
You need to log in before you can comment on or make changes to this bug.