Closed
Bug 737301
Opened 14 years ago
Closed 14 years ago
make package fails with safe browsing disabled
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla14
People
(Reporter: RyanVM, Assigned: RyanVM)
References
Details
Attachments
(1 file)
|
1.11 KB,
patch
|
khuey
:
review+
sgautherie
:
feedback-
|
Details | Diff | Splinter Review |
Due to missing ifdefs, disabling safe browsing now causes build failures due to |make package| failing on errors.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #607407 -
Flags: review?(khuey)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 607407 [details] [diff] [review]
patch
You should update removed-files.in too.
Attachment #607407 -
Flags: feedback-
Attachment #607407 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> Comment on attachment 607407 [details] [diff] [review]
> patch
>
> You should update removed-files.in too.
Why? This doesn't affect official builds where the files would be present and the files won't be there to be removed in self-made builds.
|
|
Assignee | |
Comment 4•14 years ago
|
||
Flags: in-testsuite-
Target Milestone: --- → Firefox 14
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
|
||
Updated•7 years ago
|
Target Milestone: Firefox 14 → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•