make package fails with safe browsing disabled

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Trunk
Firefox 14
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Due to missing ifdefs, disabling safe browsing now causes build failures due to |make package| failing on errors.
(Assignee)

Comment 1

5 years ago
Created attachment 607407 [details] [diff] [review]
patch
Attachment #607407 - Flags: review?(khuey)
Comment on attachment 607407 [details] [diff] [review]
patch

You should update removed-files.in too.
Attachment #607407 - Flags: feedback-
Attachment #607407 - Flags: review?(khuey) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> Comment on attachment 607407 [details] [diff] [review]
> patch
> 
> You should update removed-files.in too.

Why? This doesn't affect official builds where the files would be present and the files won't be there to be removed in self-made builds.
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/47e510cf2416
Flags: in-testsuite-
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/47e510cf2416
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 738883
You need to log in before you can comment on or make changes to this bug.