Last Comment Bug 737352 - B2G RIL: typo in RIL iccIO
: B2G RIL: typo in RIL iccIO
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Device Interfaces (show other bugs)
: Trunk
: ARM Gonk (Firefox OS)
: -- normal (vote)
: mozilla14
Assigned To: Yoshi Huang[:allstars.chh]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-20 01:14 PDT by Yoshi Huang[:allstars.chh]
Modified: 2012-03-29 08:48 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix typo in iccIO (1.01 KB, patch)
2012-03-20 20:41 PDT, Yoshi Huang[:allstars.chh]
philipp: review+
Details | Diff | Review

Description Yoshi Huang[:allstars.chh] 2012-03-20 01:14:31 PDT
This bug is a regression from Bug 735581.
the argument for EF path should be pathid, instead of path.
Comment 1 Yoshi Huang[:allstars.chh] 2012-03-20 01:45:31 PDT
Find out it's the problem of Bug 720638.
Android emulator doesn't check EF_Path argument so I get always get the number.
This also explains why I cannot get phone number on my device.
reopen Bug 720638.

*** This bug has been marked as a duplicate of bug 720638 ***
Comment 2 Philipp von Weitershausen [:philikon] 2012-03-20 18:07:50 PDT
Please don't reopen bugs for follow-up fixes. Follow-up bugs are the correct way to deal with those.
Comment 3 Yoshi Huang[:allstars.chh] 2012-03-20 20:41:16 PDT
Created attachment 607843 [details] [diff] [review]
fix typo in iccIO

Fix typo in iccIO.
It seems Ril didn't check EF Path at all so I didn't spot this typo in the first place(Bug 728638), sorry for my mistake.
Comment 4 Philipp von Weitershausen [:philikon] 2012-03-28 20:47:34 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcfebfd76082
Comment 5 Matt Brubeck (:mbrubeck) 2012-03-29 08:48:30 PDT
https://hg.mozilla.org/mozilla-central/rev/fcfebfd76082

Note You need to log in before you can comment on or make changes to this bug.