two problems: 1) Shutdown() isn't always called on nsDeviceMotion. This means that we will not unregister any hal listeners. We need to call Shutdown as we get destroyed. 2) in hal, there is a list of sensors pointed to by gSensorObservers. We need to free this as the last sensor is unregistered.
Attachment #607705 - Flags: review?(mwu)
ignore that: -static SensorObserverList *gSensorObservers = NULL; +static SensorObserverList* gSensorObservers;
(In reply to Doug Turner (:dougt) from comment #3) > ignore that: > > -static SensorObserverList *gSensorObservers = NULL; > +static SensorObserverList* gSensorObservers; I like it though. the removal of =NULL, that is. I have no opinion on which side to keep the * on.
Sorry, I backed this out because XUL Fennec was broken by one of the bugs this landed with. This can probably re-land if it doesn't depend on bug 734854. https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0b0a3c272f
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.