nsDeviceMotion w/ bug 735330 leaks mochitest-3

RESOLVED FIXED in mozilla14

Status

()

Core
Geolocation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

unspecified
mozilla14
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
two problems:

1) Shutdown() isn't always called on nsDeviceMotion.  This means that we will not unregister any hal listeners.  We need to call Shutdown as we get destroyed.

2) in hal, there is a list of sensors pointed to by gSensorObservers.  We need to free this as the last sensor is unregistered.
(Assignee)

Comment 1

5 years ago
Created attachment 607593 [details] [diff] [review]
patch v.1
Attachment #607593 - Flags: review?(mwu)
(Assignee)

Updated

5 years ago
Attachment #607593 - Attachment is obsolete: true
Attachment #607593 - Flags: review?(mwu)
(Assignee)

Comment 2

5 years ago
Created attachment 607705 [details] [diff] [review]
patch v.1

https://tbpl.mozilla.org/?tree=Try&rev=53cae499d229&pusher=dougt@mozilla.com
Attachment #607705 - Flags: review?(mwu)
(Assignee)

Comment 3

5 years ago
ignore that:

-static SensorObserverList *gSensorObservers = NULL;
+static SensorObserverList* gSensorObservers;

Updated

5 years ago
Attachment #607705 - Flags: review?(mwu) → review+

Comment 4

5 years ago
(In reply to Doug Turner (:dougt) from comment #3)
> ignore that:
> 
> -static SensorObserverList *gSensorObservers = NULL;
> +static SensorObserverList* gSensorObservers;

I like it though. the removal of =NULL, that is. I have no opinion on which side to keep the * on.
Sorry, I backed this out because XUL Fennec was broken by one of the bugs this landed with.  This can probably re-land if it doesn't depend on bug 734854.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0b0a3c272f
https://hg.mozilla.org/mozilla-central/rev/3d6c7cf537de
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.