737462 - nsDeviceMotion w/ bug 735330 leaks mochitest-3

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Doug Turner (:dougt)]

two problems:

1) Shutdown() isn't always called on nsDeviceMotion.  This means that we will not unregister any hal listeners.  We need to call Shutdown as we get destroyed.

2) in hal, there is a list of sensors pointed to by gSensorObservers.  We need to free this as the last sensor is unregistered.

Comment 1

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 2

[Doug Turner (:dougt)]

Attachment: patch v.1

https://tbpl.mozilla.org/?tree=Try&rev=53cae499d229&pusher=[e-mail]

Comment 3

[Doug Turner (:dougt)]

ignore that:

-static SensorObserverList *gSensorObservers = NULL;
+static SensorObserverList* gSensorObservers;

Comment 4

[Michael Wu [:mwu]]

(In reply to Doug Turner (:dougt) from comment #3)
> ignore that:
> 
> -static SensorObserverList *gSensorObservers = NULL;
> +static SensorObserverList* gSensorObservers;

I like it though. the removal of =NULL, that is. I have no opinion on which side to keep the * on.

Comment 5

[Matt Brubeck (:mbrubeck)]

Sorry, I backed this out because XUL Fennec was broken by one of the bugs this landed with.  This can probably re-land if it doesn't depend on bug 734854.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0b0a3c272f

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/3d6c7cf537de