Menulists and textboxes need better styling in add-on options
VERIFIED
FIXED
in Firefox 13
Status
()
People
(Reporter: mbrubeck, Assigned: mbrubeck)
Tracking
Firefox Tracking Flags
(firefox13 fixed, firefox14 verified, blocking-fennec1.0 -, fennec13+)
Details
Attachments
(2 attachments)
|
2.24 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
|
81.98 KB,
image/png
|
Details |
screenshot
Created attachment 607772 [details] [diff] [review] patch This makes XUL menulists and textboxes larger (more touch-friendly) and prettier on about:addons. The styles are basically copied from the HTML content theme. It also disables spinbuttons on <textbox type="number"> widgets. I'll file a follow-up bug to bring back the spinbuttons with a touch-friendly theme like in XUL Fennec. Nominating for blocking because many add-on options are not really usable without this change.
Attachment #607772 -
Flags: review?(mark.finkle)
|
||
Comment 1•7 years ago
|
||
Comment on attachment 607772 [details] [diff] [review] patch Looks good. Get an OK from Patryk too, from a screenshot? Also, for number textboxes, do we use the number-centric soft-keyboard? I know we can use a attribute to get the VKB to show a keyboard with a numpad on it.
Attachment #607772 -
Flags: review?(mark.finkle) → review+
|
(Assignee) | |
Comment 2•7 years ago
|
||
Created attachment 607866 [details] screenshot How's this look, Patryk? For comparison, current builds look basically like attachment 601991 [details]. If you'd like to make changes at this stage, we can polish things up here, or open a followup bug if you want to provide whole new mockups or assets. (In reply to Mark Finkle (:mfinkle) from comment #1) > Also, for number textboxes, do we use the number-centric soft-keyboard? No; I'll submit a follow-up bug for that.
Attachment #607866 -
Flags: review?(padamczyk)
|
|
(Assignee) | |
Comment 3•7 years ago
|
||
(In reply to Matt Brubeck (:mbrubeck) from comment #2) > > Also, for number textboxes, do we use the number-centric soft-keyboard? > > No; I'll submit a follow-up bug for that. Filed bug 638143.
|
|
||
Updated•7 years ago
|
tracking-fennec: --- → 13+
blocking-fennec1.0: ? → -
|
|
(Assignee) | |
Updated•7 years ago
|
Attachment #607866 -
Flags: review?(padamczyk)
|
|
(Assignee) | |
Comment 4•7 years ago
|
||
Landed with some layout tweaks requested by Patryk on IRC: https://hg.mozilla.org/integration/mozilla-inbound/rev/d34c8cafbdb1
Target Milestone: --- → Firefox 14
|
||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d34c8cafbdb1
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/47135409a694
status-firefox13: --- → fixed
status-firefox14: --- → fixed
|
||
Comment 7•7 years ago
|
||
Tested using the Zippity Testharness2.0 from http://people.mozilla.com/~mfinkle/addons/. Verified fix on: Nightly 2012-06-01/ Aurora 2012-06-01 Device: HTC Desire OS: Android 2.2
Status: RESOLVED → VERIFIED
status-firefox14: fixed → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•