737692 - Menulists and textboxes need better styling in add-on options

Status: VERIFIED FIXED

(Firefox for Android :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This makes XUL menulists and textboxes larger (more touch-friendly) and prettier on about:addons.  The styles are basically copied from the HTML content theme.

It also disables spinbuttons on <textbox type="number"> widgets.  I'll file a follow-up bug to bring back the spinbuttons with a touch-friendly theme like in XUL Fennec.

Nominating for blocking because many add-on options are not really usable without this change.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 607772 [details] [diff] [review]
patch

Looks good. Get an OK from Patryk too, from a screenshot?

Also, for number textboxes, do we use the number-centric soft-keyboard? I know we can use a attribute to get the VKB to show a keyboard with a numpad on it.

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: screenshot

How's this look, Patryk?  For comparison, current builds look basically like attachment 601991 [details].  If you'd like to make changes at this stage, we can polish things up here, or open a followup bug if you want to provide whole new mockups or assets.

(In reply to Mark Finkle (:mfinkle) from comment #1)
> Also, for number textboxes, do we use the number-centric soft-keyboard?

No; I'll submit a follow-up bug for that.

Comment 3

[Matt Brubeck (:mbrubeck)]

(In reply to Matt Brubeck (:mbrubeck) from comment #2)
> > Also, for number textboxes, do we use the number-centric soft-keyboard?
> 
> No; I'll submit a follow-up bug for that.

Filed bug 638143.

Comment 4

[Matt Brubeck (:mbrubeck)]

Landed with some layout tweaks requested by Patryk on IRC:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d34c8cafbdb1

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d34c8cafbdb1

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/47135409a694

Comment 7

[Adrian Tamas (:AdrianT)]

Tested using the Zippity Testharness2.0 from http://people.mozilla.com/~mfinkle/addons/. 
Verified fix on:
Nightly 2012-06-01/ Aurora 2012-06-01
Device: HTC Desire 
OS: Android 2.2